Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suisin/coj406/upgrade your mt5 account popup #12271

Conversation

suisin-deriv
Copy link
Contributor

@suisin-deriv suisin-deriv commented Dec 14, 2023

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 4, 2024 11:06am

Copy link
Contributor

github-actions bot commented Dec 14, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12271](https://github.com/binary-com/deriv-app/pull/12271)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-coj406upgradeyour-3c365c.binary.sx?qa_server=red.derivws.com&app_id=31483
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-coj406upgradeyour-3c365c.binary.sx
- **App ID**: `31483`

Copy link
Contributor

github-actions bot commented Dec 14, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-coj406upgradeyour-3c365c.binary.sx/

@coveralls
Copy link

coveralls commented Dec 29, 2023

Coverage Status

coverage: 34.176% (-0.02%) from 34.191%
when pulling a37c02e on suisin-deriv:suisin/COJ406/upgrade_your_mt5_account_popup
into 7775c6a on binary-com:master.

amina-deriv
amina-deriv previously approved these changes Dec 29, 2023
Copy link
Contributor

@amina-deriv amina-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shahzaib-deriv
shahzaib-deriv previously approved these changes Jan 2, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
10.6% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@amina-deriv amina-deriv merged commit d2cd2f3 into binary-com:master Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants