Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WALL] [Fix] Rostislav / WALL-3134 & 3136 / Pending transactions UI issues #12460

Merged
merged 4 commits into from
Dec 22, 2023
Merged

[WALL] [Fix] Rostislav / WALL-3134 & 3136 / Pending transactions UI issues #12460

merged 4 commits into from
Dec 22, 2023

Conversation

rostislav-deriv
Copy link
Contributor

@rostislav-deriv rostislav-deriv commented Dec 21, 2023 •
edited
Loading

Changes:

  • fix conditions for displaying completed and pending transactions
  • fix cropped tooltip for pending transactions
  • pending transactions transaction hash NA -> Pending if there's no hash received
  • "Confirmations" now aligned left as are all fields

Screenshots:

Screenshot 2023-12-21 at 19 17 13

@vercel Vercel
Copy link

vercel bot commented Dec 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 22, 2023 11:09am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 21, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/12460](https://github.com/binary-com/deriv-app/pull/12460)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rostislav-deriv-rostislav-wall-3134fi-3189e8.binary.sx?qa_server=red.derivws.com&app_id=32108
    - **Original**: https://deriv-app-git-fork-rostislav-deriv-rostislav-wall-3134fi-3189e8.binary.sx
- **App ID**: `32108`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 21, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-rostislav-deriv-rostislav-wall-3134fi-3189e8.binary.sx/

@coveralls
Copy link

coveralls commented Dec 21, 2023 •
edited
Loading

Coverage Status

coverage: 33.768% (+0.001%) from 33.767%
when pulling b6fe820 on rostislav-deriv:rostislav/wall-3134/fix-trasnsactions-bad-conditions
into 3d8bdff on binary-com:master.

@rostislav-deriv rostislav-deriv force-pushed the rostislav/wall-3134/fix-trasnsactions-bad-conditions branch from 9c48aa8 to 184d27c Compare December 22, 2023 09:32
@rostislav-deriv rostislav-deriv force-pushed the rostislav/wall-3134/fix-trasnsactions-bad-conditions branch from 184d27c to 3b4325c Compare December 22, 2023 10:37
@rostislav-deriv rostislav-deriv force-pushed the rostislav/wall-3134/fix-trasnsactions-bad-conditions branch from 3b4325c to b6fe820 Compare December 22, 2023 10:39
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 22, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@nijil-deriv nijil-deriv merged commit 23c23d2 into binary-com:master Dec 22, 2023
6 checks passed
lubega-deriv pushed a commit to lubega-deriv/deriv-app that referenced this pull request Dec 26, 2023
@rostislav-deriv @lubega-deriv
[WALL] [Fix] Rostislav / WALL-3134 & 3136 / Pending transactions UI i…
a4d5ea0 
…ssues (binary-com#12460)

* fix: the thing

* fix: correction + other bug

* fix: more of wall-3136

* fix: don't center confirmations on desktop

Signed-off-by: lubega-deriv <lubega@deriv.com>
lubega-deriv pushed a commit to lubega-deriv/deriv-app that referenced this pull request Dec 26, 2023
@rostislav-deriv @lubega-deriv
[WALL] [Fix] Rostislav / WALL-3134 & 3136 / Pending transactions UI i…
7918bfa 
…ssues (binary-com#12460)

* fix: the thing

* fix: correction + other bug

* fix: more of wall-3136

* fix: don't center confirmations on desktop

Signed-off-by: lubega-deriv <lubega@deriv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nijil-deriv nijil-deriv nijil-deriv approved these changes

@heorhi-deriv heorhi-deriv heorhi-deriv approved these changes

@farhan-nurzi-deriv farhan-nurzi-deriv farhan-nurzi-deriv approved these changes

@wojciech-deriv wojciech-deriv wojciech-deriv approved these changes

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv adrienne-deriv is a code owner

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv thisyahlen-deriv is a code owner

@aizad-deriv aizad-deriv Awaiting requested review from aizad-deriv aizad-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rostislav-deriv @coveralls @nijil-deriv @heorhi-deriv @farhan-nurzi-deriv @wojciech-deriv