-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COJ] KYC / lazy load onfido script on demand while verification #12554
[COJ] KYC / lazy load onfido script on demand while verification #12554
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-kyc-lazy-load-onfido-script.binary.sx/ |
packages/account/src/Sections/Verification/ProofOfIdentity/onfido-sdk-view-container.tsx
Outdated
Show resolved
Hide resolved
packages/account/src/Sections/Verification/ProofOfIdentity/onfido-sdk-view-container.tsx
Outdated
Show resolved
Hide resolved
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
❌ Smoke test run (1) failed. See logs for details: Visit Action |
❌ Smoke test run (2) failed. See logs for details: Visit Action |
❌ Smoke test run (2) failed. See logs for details: Visit Action |
❌ Smoke test run (1) failed. See logs for details: Visit Action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👌
Changes:
This PR focuses on loading Onfido SDK script on demand upon navigates to KYC screen for verification which improves site loading by preventing the load of a Onfido SDK and CSS files on site load.