Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COJ] KYC / lazy load onfido script on demand while verification #12554

Merged

Conversation

shahzaib-deriv
Copy link
Contributor

@shahzaib-deriv shahzaib-deriv commented Dec 27, 2023

Changes:

This PR focuses on loading Onfido SDK script on demand upon navigates to KYC screen for verification which improves site loading by preventing the load of a Onfido SDK and CSS files on site load.

Copy link

vercel bot commented Dec 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 4, 2024 6:43am

Copy link
Contributor

github-actions bot commented Dec 27, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12554](https://github.com/binary-com/deriv-app/pull/12554)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-kyc-lazy-load-onfido-script.binary.sx?qa_server=red.derivws.com&app_id=23934
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-kyc-lazy-load-onfido-script.binary.sx
- **App ID**: `23934`

Copy link
Contributor

github-actions bot commented Dec 27, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-kyc-lazy-load-onfido-script.binary.sx/

@coveralls
Copy link

coveralls commented Dec 27, 2023

Coverage Status

coverage: 34.233% (+0.005%) from 34.228%
when pulling be0a863 on shahzaib-deriv:KYC/lazy-load-onfido-script
into 86bc009 on binary-com:master.

@shahzaib-deriv shahzaib-deriv changed the title chore: lazy load onfido script on demand while verification [COJ] KYC / lazy load onfido script on demand while verification Dec 28, 2023
likhith-deriv
likhith-deriv previously approved these changes Dec 28, 2023
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
12.5% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

@amina-deriv amina-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👌

@likhith-deriv likhith-deriv merged commit dd14b7d into binary-com:master Jan 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants