Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH] shontzu/TRAH-2343/show-dxtrade-in-tradershub-rout4e #12569

Conversation

shontzu-deriv
Copy link
Contributor

@shontzu-deriv shontzu-deriv commented Dec 28, 2023

Changes:

Screenshots:

image

Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 28, 2023 7:29am

Copy link
Contributor

github-actions bot commented Dec 28, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12569](https://github.com/binary-com/deriv-app/pull/12569)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shontzu-deriv-shontzu-trah-2343show-d-3f2e68.binary.sx?qa_server=red.derivws.com&app_id=38778
    - **Original**: https://deriv-app-git-fork-shontzu-deriv-shontzu-trah-2343show-d-3f2e68.binary.sx
- **App ID**: `38778`

@coveralls
Copy link

coveralls commented Dec 28, 2023

Coverage Status

coverage: 33.992% (-0.04%) from 34.027%
when pulling 7cf206c on shontzu-deriv:shontzu/TRAH-2343/show-dxtrade-in-tradershub-rout4e
into 8830209 on binary-com:master.

Copy link
Contributor

github-actions bot commented Dec 28, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-trah-2343show-d-3f2e68.binary.sx/

hamza-deriv
hamza-deriv previously approved these changes Dec 28, 2023
hamza-deriv
hamza-deriv previously approved these changes Dec 28, 2023
Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@mahdiyeh-deriv mahdiyeh-deriv merged commit 2b05ee2 into binary-com:master Dec 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants