Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trah]Thisyahlen/trah 2307/dxtrade password modal #12584

Conversation

thisyahlen-deriv
Copy link
Contributor

Changes:

  1. Add dxtrade password modal

Screenshots:

Screenshot 2023-12-28 at 5 15 32 PM

Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 29, 2023 3:16am

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Dec 28, 2023
@coveralls
Copy link

coveralls commented Dec 28, 2023

Coverage Status

coverage: 34.024% (+0.002%) from 34.022%
when pulling 0b07e1d on thisyahlen-deriv:thisyahlen/TRAH-2307/dxtrade_password_modal
into 7bc8fdc on binary-com:master.

Copy link
Contributor

github-actions bot commented Dec 28, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12584](https://github.com/binary-com/deriv-app/pull/12584)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-trah-2307-f27d0d.binary.sx?qa_server=red.derivws.com&app_id=31528
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-trah-2307-f27d0d.binary.sx
- **App ID**: `31528`

Copy link
Contributor

github-actions bot commented Dec 28, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-trah-2307-f27d0d.binary.sx/

Copy link

sonarcloud bot commented Dec 29, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@hirad-deriv hirad-deriv merged commit e3280b0 into binary-com:master Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trader's Hub PR's that are created to the new trader's hub package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants