Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRAH] Aizad/TRAH-2268/DemoRealAccountSwitcher #12635

Merged
merged 24 commits into from
Jan 5, 2024
Merged

[TRAH] Aizad/TRAH-2268/DemoRealAccountSwitcher #12635

merged 24 commits into from
Jan 5, 2024

Conversation

aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Dec 29, 2023 •
edited
Loading

Changes:

  • Created DemoRealAccountSwitcher component
  • Incorporate within Tradershub header

Screenshots:

![image](https://github.com/binary-com/deriv-app/assets/103104395/b4

Screen.Recording.2024-01-02.at.12.47.46.PM.mov

5f93ee-82f9-43a1-9979-6430b198db95)

@vercel Vercel
Copy link

vercel bot commented Dec 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 5, 2024 2:38am

@coveralls
Copy link

coveralls commented Dec 29, 2023 •
edited
Loading

Coverage Status

Changes unknown
when pulling 0b2c402 on aizad-deriv:aizad/TRAH-2268/real-demo-switcher
into ** on binary-com:master**.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 29, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/12635](https://github.com/binary-com/deriv-app/pull/12635)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-trah-2268real-demo-39efe5.binary.sx?qa_server=red.derivws.com&app_id=24195
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-trah-2268real-demo-39efe5.binary.sx
- **App ID**: `24195`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 29, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-trah-2268real-demo-39efe5.binary.sx/

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Jan 2, 2024
@aizad-deriv aizad-deriv force-pushed the aizad/TRAH-2268/real-demo-switcher branch from 8fb9060 to b5afdd1 Compare January 2, 2024 04:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@hirad-deriv hirad-deriv merged commit 38956f9 into binary-com:master Jan 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matin-deriv matin-deriv matin-deriv left review comments

@mahdiyeh-deriv mahdiyeh-deriv mahdiyeh-deriv left review comments

@sergei-deriv sergei-deriv sergei-deriv left review comments

@hirad-deriv hirad-deriv hirad-deriv approved these changes

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv approved these changes

@hamza-deriv hamza-deriv hamza-deriv left review comments

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv

@farhan-nurzi-deriv farhan-nurzi-deriv Awaiting requested review from farhan-nurzi-deriv

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

Assignees

@aizad-deriv aizad-deriv

Labels
Trader's Hub PR's that are created to the new trader's hub package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aizad-deriv @coveralls @matin-deriv @mahdiyeh-deriv @hirad-deriv @thisyahlen-deriv @hamza-deriv @sergei-deriv