-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WALL] Farhan/WALL-3060/POI Icon variation in MT5 Derived & Financial does not match Figma #12694
[WALL] Farhan/WALL-3060/POI Icon variation in MT5 Derived & Financial does not match Figma #12694
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… farhan/WALL-3060/poi-icon-doesnt-match-figma
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-3060po-7bbdf6.binary.sx/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make the test statements more specific?
it('should return verification docs for idv unsupported country'
and
it('should return verification docs for idv supported country',
The difference between these 2 statements is not clear, for example.
...s/wallets/src/features/cfd/screens/Jurisdiction/hooks/__tests__/useVerificationDocs.spec.tsx
Show resolved
Hide resolved
… farhan/WALL-3060/poi-icon-doesnt-match-figma
… farhan/WALL-3060/poi-icon-doesnt-match-figma
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
❌ Smoke test run (1) failed. See logs for details: Visit Action |
❌ Smoke test run (1) failed. See logs for details: Visit Action |
❌ Smoke test run (2) failed. See logs for details: Visit Action |
Changes:
Fix icons indicator in jurisdiction modal, to check on the current poi
Screenshots:
Client with unsupported idv country or hasnt attempt idv yet
Client that support idv