Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Farhan/WALL-3060/POI Icon variation in MT5 Derived & Financial does not match Figma #12694

Conversation

farhan-nurzi-deriv
Copy link
Contributor

Changes:

Fix icons indicator in jurisdiction modal, to check on the current poi

Screenshots:

Client with unsupported idv country or hasnt attempt idv yet

image

Client that support idv

image

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 5, 2024 8:04am

Copy link
Contributor

github-actions bot commented Jan 3, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12694](https://github.com/binary-com/deriv-app/pull/12694)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-3060po-7bbdf6.binary.sx?qa_server=red.derivws.com&app_id=24058
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-3060po-7bbdf6.binary.sx
- **App ID**: `24058`

Copy link
Contributor

github-actions bot commented Jan 3, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-3060po-7bbdf6.binary.sx/

@coveralls
Copy link

coveralls commented Jan 3, 2024

Coverage Status

coverage: 34.678% (+0.02%) from 34.66%
when pulling 1649b2b on farhan-nurzi-deriv:farhan/WALL-3060/poi-icon-doesnt-match-figma
into b2a4aa8 on binary-com:master.

Copy link
Contributor

@nijil-deriv nijil-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the test statements more specific?
it('should return verification docs for idv unsupported country'
and
it('should return verification docs for idv supported country',
The difference between these 2 statements is not clear, for example.

Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
5.1% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@nijil-deriv nijil-deriv merged commit 88cd7df into binary-com:master Jan 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants