Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] george / WALL-3170 / The header part of the dropdown moves when scrolling within the dropdown in iPhone #12713

Conversation

heorhi-deriv
Copy link
Contributor

Changes:

  • fix header part of the dropdown alignment when scrolling the page on iPhone devices

Screenshots:

Screen.Recording.2024-01-03.at.17.32.57.mov

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 4, 2024 6:24am

…e-dropdown-moves-when-scrolling-within-the-dropdown-in-iPhone-
Copy link
Contributor

github-actions bot commented Jan 3, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12713](https://github.com/binary-com/deriv-app/pull/12713)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-wall-3170-the-header-par-12b651.binary.sx?qa_server=red.derivws.com&app_id=24071
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-wall-3170-the-header-par-12b651.binary.sx
- **App ID**: `24071`

Copy link
Contributor

github-actions bot commented Jan 3, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-wall-3170-the-header-par-12b651.binary.sx/

@coveralls
Copy link

coveralls commented Jan 3, 2024

Coverage Status

coverage: 34.248% (+5.2%) from 29.037%
when pulling d36cd2d on heorhi-deriv:WALL-3170-The-header-part-of-the-dropdown-moves-when-scrolling-within-the-dropdown-in-iPhone-
into 329d6db on binary-com:master.

…e-dropdown-moves-when-scrolling-within-the-dropdown-in-iPhone-
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
11.5% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@nijil-deriv nijil-deriv merged commit 2d74c29 into binary-com:master Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants