Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] george / WALL-3167 / The 'transfer to' option does not deselect after changing the 'transfer from' #12732

Conversation

heorhi-deriv
Copy link
Contributor

Changes:

  • fix account selection

Screenshots:

Screen.Recording.2024-01-04.at.10.37.29.mov

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 4, 2024 0:08am

…ion-does-not-deselect-after-changing-the-'transfer-from
Copy link
Contributor

github-actions bot commented Jan 4, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12732](https://github.com/binary-com/deriv-app/pull/12732)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-wall-3167-the-transfer-t-103572.binary.sx?qa_server=red.derivws.com&app_id=32227
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-wall-3167-the-transfer-t-103572.binary.sx
- **App ID**: `32227`

Copy link
Contributor

github-actions bot commented Jan 4, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-wall-3167-the-transfer-t-103572.binary.sx/

Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 34.484% (+0.01%) from 34.473%
when pulling cc4c81a on heorhi-deriv:WALL-3167-The-'transfer-to'-option-does-not-deselect-after-changing-the-'transfer-from
into 0373314 on binary-com:master.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@nijil-deriv nijil-deriv merged commit 9ba2e69 into binary-com:master Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants