Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thisyahlen/TRAH-2622/chore: switching logic in real demo dropdown #12762

Conversation

thisyahlen-deriv
Copy link
Contributor

Changes:

  1. Implement switching logic in the real demo dropdown

Screenshots:

Screen.Recording.2024-01-05.at.3.08.13.PM.mov

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Jan 5, 2024
@thisyahlen-deriv thisyahlen-deriv self-assigned this Jan 5, 2024
Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 5, 2024 7:35am

Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 34.665% (-0.001%) from 34.666%
when pulling a04979c on thisyahlen-deriv:thisyahlen/real_demo_switcher_logic
into 69134ea on binary-com:master.

Copy link
Contributor

github-actions bot commented Jan 5, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12762](https://github.com/binary-com/deriv-app/pull/12762)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-realdemos-d6fd97.binary.sx?qa_server=red.derivws.com&app_id=23848
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-realdemos-d6fd97.binary.sx
- **App ID**: `23848`

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-realdemos-d6fd97.binary.sx/

@hirad-deriv hirad-deriv merged commit 9188660 into binary-com:master Jan 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trader's Hub PR's that are created to the new trader's hub package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants