Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] george / WALL-3220 / The padding size between cards in the success page does not align with design.(Mobile view) #12773

Conversation

heorhi-deriv
Copy link
Contributor

@heorhi-deriv heorhi-deriv commented Jan 5, 2024

Changes:

  • fix gap
  • fix content (remove space in card balance)

Screenshots:

Screenshot 2024-01-05 at 11 34 17
Screenshot 2024-01-05 at 12 42 35

Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 5, 2024 9:59am

matin-deriv
matin-deriv previously approved these changes Jan 5, 2024
@coveralls
Copy link

coveralls commented Jan 5, 2024

Coverage Status

coverage: 34.656% (+0.001%) from 34.655%
when pulling b609cb8 on heorhi-deriv:WALL-3220-The-padding-size-between-cards-in-the-success-page-does-not-align-with-design.(Mobile-view)
into dced240 on binary-com:master.

Copy link
Contributor

github-actions bot commented Jan 5, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12773](https://github.com/binary-com/deriv-app/pull/12773)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-wall-3220-the-padding-si-983216.binary.sx?qa_server=red.derivws.com&app_id=23848
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-wall-3220-the-padding-si-983216.binary.sx
- **App ID**: `23848`

Copy link
Contributor

github-actions bot commented Jan 5, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-wall-3220-the-padding-si-983216.binary.sx/

Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Generating Lighthouse report...

@nijil-deriv nijil-deriv merged commit ce324a6 into binary-com:master Jan 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants