Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] aum/WALL-3248/pending-transactions-tab-remove-zero-after-date #12817

Conversation

aum-deriv
Copy link
Contributor

@aum-deriv aum-deriv commented Jan 8, 2024

Changes:

🐛 fix: In responsive view, remove 0 coming after the date in pending transactions under transactions tab.

Screenshot 2024-01-08 at 6 00 55 PM

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 8, 2024 2:28pm

…L-3248/pending-transactions-tab-remove-zero-after-date
Copy link
Contributor

github-actions bot commented Jan 8, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12817](https://github.com/binary-com/deriv-app/pull/12817)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aum-deriv-aum-wall-3248pending-transa-92fc22.binary.sx?qa_server=red.derivws.com&app_id=23879
    - **Original**: https://deriv-app-git-fork-aum-deriv-aum-wall-3248pending-transa-92fc22.binary.sx
- **App ID**: `23879`

Copy link
Contributor

github-actions bot commented Jan 8, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-aum-deriv-aum-wall-3248pending-transa-92fc22.binary.sx/

Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
10.6% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Jan 8, 2024

Coverage Status

coverage: 34.743%. remained the same
when pulling dd834af on aum-deriv:aum/WALL-3248/pending-transactions-tab-remove-zero-after-date
into 7250402 on binary-com:master.

@aum-deriv aum-deriv changed the title [Draft] [WALL] aum/WALL-3248/pending-transactions-tab-remove-zero-after-date [WALL] aum/WALL-3248/pending-transactions-tab-remove-zero-after-date Jan 8, 2024
@aum-deriv aum-deriv marked this pull request as ready for review January 8, 2024 14:28
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Generating Lighthouse report...

@nijil-deriv nijil-deriv merged commit de70fdb into binary-com:master Jan 8, 2024
8 checks passed
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 8, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants