[TRAH] Aizad/TRAH-2627/Currency Switcher Modal for responsive #12827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added modal id inside of AppContent - change ModalStepWrapper to Modal - change tailwind classes for Modal to accommodate responsive view
aizad-deriv
requested review from
balakrishna-deriv and
yashim-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aizad-deriv
added
the
Trader's Hub
aizad-deriv
changed the title
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
Changes unknown |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-trah-2627trading-ac-e5fab8.binary.sx/ |
…TRAH-2627/trading-account-list-responsive
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
packages/tradershub/src/components/CurrencySwitcher/CurrencySwitcher.tsx
Show resolved
Hide resolved
|
thisyahlen-deriv
approved these changes
Jan 9, 2024
shontzu-deriv
approved these changes
Jan 9, 2024
mahdiyeh-deriv
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Screenshots:
Screen.Recording.2024-01-09.at.3.26.47.PM.mov