chore: [UPM-923]/evgeniy/error message for passkey not supported device #14723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yauheni-deriv
requested review from
matin-deriv,
amina-deriv and
maryia-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-yauheni-deriv-upm-923add-not-supporte-96766b.binary.sx/ |
packages/account/src/Sections/Security/Passkeys/passkeys-configs.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
previously approved these changes
Apr 22, 2024
matin-deriv
previously approved these changes
Apr 22, 2024
yauheni-deriv
dismissed stale reviews from matin-deriv and amina-deriv
via
2d90f60
amina-deriv
reviewed
Apr 23, 2024
packages/account/src/Sections/Security/Passkeys/passkeys-configs.tsx
Outdated
Show resolved
Hide resolved
yauheni-deriv
requested review from
thisyahlen-deriv,
amina-deriv and
likhith-deriv
thisyahlen-deriv
previously approved these changes
Apr 26, 2024
suisin-deriv
approved these changes
Apr 26, 2024
|
amina-deriv
approved these changes
Apr 26, 2024
|
⏳ Generating Lighthouse report... |
vinu-deriv
pushed a commit
to vinu-deriv/deriv-app
that referenced
this pull request
May 28, 2024
…ce (binary-com#14723) * chore: [UPM-923]/evgeniy/error message for passkey not supported device * fix: read of undefined * chore: added new button text and action for not supported * fix: error variable name * chore: update content in passkey-config (binary-com#42) * fix: content for unsupported error * Suisin/solve passkey header issue (binary-com#43) * chore: fix header not bold issue * chore: update passkey creation fail content * chore: refactor error content * chore: added comment to remove is_tour_open * chore: remove close icon for error modal * chore: remove close icon for error modal --------- Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Added the check for error code to show custom error for not supported device