Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ahmad/DTRA-1401/DTRA-1402/Add currency in payout per point and decimal point in take profit #16012

Merged
merged 8 commits into from
Jul 22, 2024
Merged

Ahmad/DTRA-1401/DTRA-1402/Add currency in payout per point and decimal point in take profit #16012

merged 8 commits into from
Jul 22, 2024

Conversation

ahmadtaimoor-deriv
Copy link
Contributor

In the PR,
I added currency display in the payout per point section on the Turbo Contract Details page.
I updated the Take Profit field to show values up to 2 decimal places on the Accumulator Contract Details page.

@boring-cyborg boring-cyborg bot added the Trader label Jul 10, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 22, 2024 9:54am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/16012](https://github.com/binary-com/deriv-app/pull/16012)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ahmadtaimoor-deriv-fixv2contract-details.binary.sx?qa_server=red.derivws.com&app_id=31547
    - **Original**: https://deriv-app-git-fork-ahmadtaimoor-deriv-fixv2contract-details.binary.sx
- **App ID**: `31547`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 39
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-ahmadtaimoor-deriv-fixv2contract-details.binary.sx/

@coveralls
Copy link

coveralls commented Jul 10, 2024 •
edited
Loading

Coverage Status

coverage: 45.331% (+0.08%) from 45.252%
when pulling 4437e5e on ahmadtaimoor-deriv:fix_v2_contract-details
into a8b18ea on binary-com:master.

@balakrishna-deriv balakrishna-deriv changed the base branch from master to position-and-contract-details-fixes July 22, 2024 09:17
@balakrishna-deriv balakrishna-deriv merged commit c42c12f into binary-com:position-and-contract-details-fixes Jul 22, 2024
2 of 3 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

vinu-deriv pushed a commit that referenced this pull request Aug 27, 2024
@balakrishna-deriv @ahmadtaimoor-deriv
@kate-deriv @akmal-deriv
[DTRA-1306] DTRA/DTrader V2 Position and contract details fixes (#16149)
bc9bcb5 
* Ahmad/DTRA-1408/Fix Vanilla Contract in Contract Details V2 (#16018)

* fix: decimal point

* fix: currency in payoutperpoint

* fix: vanillas

* fix: only vanilla

* fix: test coverage

* Ahmad/DTRA-1405/Multipliers fix on Contract Details V2 (#16017)

* fix: multiplier

* fix: testcase

* fix: fix

* fix: deal cancel

* chore: add DC

* chore: suggestion

* chore:fix

* fix: test case fix

* Ahmad/DTRA-1401/DTRA-1402/Add currency in payout per point and decimal point in take profit (#16012)

* fix: decimal point

* fix: currency in payoutperpoint

* fix: vanillas

* fix: test case and comments

* chore: review fix

* fix: indent

---------

Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com>

* fix: bugs with resetting filter and icon for hight low (#16003)

Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com>

* Akmal / fix: pass currency across closed positions and contract details (#16161)

* fix: pass currency across closed positions and contract details

* fix: add a comment

* [DTRA]/Ahmad/DTRA-1490/Deal Cancellation Status Fix Trader-V2 (#16121)

* fix: cancellation active, executed and expired

* chore: revert last commit

* DTRA-1569 / Kate / Filter resetting issue (#16359)

* fix: resetting filter issue

* refactor: add date clear on unmount

* refactor: tests

* fix: tests

* fix: console error

* Akmal / fix: wrong duration unit for digit contracts (#16378)

* fix: wrong duration unit for digit contracts

* fix: test case

* Akmal / fix: take profit & stop loss decimals (#16195)

* fix: remove decimals from take profit

* fix: apply fixes from quill library

* fix: apply dynamic decimal places based on currency

* feat: update quill-ui version

---------

Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com>
Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com>
Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akmal-deriv akmal-deriv akmal-deriv left review comments

@balakrishna-deriv balakrishna-deriv balakrishna-deriv approved these changes

@maryia-deriv maryia-deriv maryia-deriv approved these changes

@kate-deriv kate-deriv kate-deriv approved these changes

@matin-deriv matin-deriv Awaiting requested review from matin-deriv

Assignees
No one assigned
Labels
Trader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ahmadtaimoor-deriv @coveralls @balakrishna-deriv @akmal-deriv @maryia-deriv @kate-deriv