Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2PS] farrah/P2PS-2815/fix: add leave page modal #16103

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

farrah-deriv
Copy link
Contributor

Changes:

Show the LeavePageModal component if there's any change when selecting the preferred countries.

Screenshots:

Screenshot 2024-07-17 at 4 05 54 PM

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 27, 2024 6:16am

Copy link
Contributor

github-actions bot commented Jul 17, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16103](https://github.com/binary-com/deriv-app/pull/16103)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farrah-deriv-p2ps-2815-leave-page.binary.sx?qa_server=red.derivws.com&app_id=32766
    - **Original**: https://deriv-app-git-fork-farrah-deriv-p2ps-2815-leave-page.binary.sx
- **App ID**: `32766`

Copy link
Contributor

github-actions bot commented Jul 17, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 38
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-farrah-deriv-p2ps-2815-leave-page.binary.sx/

@coveralls
Copy link

coveralls commented Jul 17, 2024

Coverage Status

coverage: 46.887% (+0.001%) from 46.886%
when pulling 443b0f1 on farrah-deriv:P2PS-2815/leave-page
into 3a2ab81 on binary-com:master.

nada-deriv
nada-deriv previously approved these changes Aug 12, 2024
Copy link

sonarcloud bot commented Aug 27, 2024

@farrah-deriv farrah-deriv merged commit 1d8b72a into binary-com:master Aug 27, 2024
8 checks passed
Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants