Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] [WEBREL] aum / WEBREL-3055 / wallet-password-validation-error-DerivX-MT5 #16364

Conversation

aum-deriv
Copy link
Contributor

Changes:

Fix error message shown during password field validation for MT5 and DerivX accounts.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 5, 2024 2:29pm

@aum-deriv aum-deriv changed the title aum/WEBREL-3055/wallet-password-validation-error-DerivX-MT5 [WALL] [WEBREL] aum/WEBREL-3055/wallet-password-validation-error-DerivX-MT5 Aug 5, 2024
@aum-deriv aum-deriv changed the title [WALL] [WEBREL] aum/WEBREL-3055/wallet-password-validation-error-DerivX-MT5 [WALL] [WEBREL] aum / WEBREL-3055 / wallet-password-validation-error-DerivX-MT5 Aug 5, 2024
@aum-deriv aum-deriv marked this pull request as ready for review August 5, 2024 13:04
Copy link
Contributor

github-actions bot commented Aug 5, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16364](https://github.com/binary-com/deriv-app/pull/16364)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aum-deriv-aum-webrel-3055wallet-passw-b58fdc.binary.sx?qa_server=red.derivws.com&app_id=38677
    - **Original**: https://deriv-app-git-fork-aum-deriv-aum-webrel-3055wallet-passw-b58fdc.binary.sx
- **App ID**: `38677`

Copy link
Contributor

github-actions bot commented Aug 5, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 35
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aum-deriv-aum-webrel-3055wallet-passw-b58fdc.binary.sx/

@coveralls
Copy link

coveralls commented Aug 5, 2024

Coverage Status

coverage: 46.55% (-0.001%) from 46.551%
when pulling 133f296 on aum-deriv:aum/WEBREL-3055/wallet-password-validation-error-DerivX-MT5
into 335f744 on binary-com:master.

@aum-deriv aum-deriv force-pushed the aum/WEBREL-3055/wallet-password-validation-error-DerivX-MT5 branch from 129cfff to 66fad2f Compare August 5, 2024 13:55
Copy link

sonarcloud bot commented Aug 5, 2024

@heorhi-deriv heorhi-deriv merged commit 4605304 into binary-com:rc_V20240802_0 Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants