Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-3521 / Cashier menu and header translations fix #16429

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Added current language to the getMenuOptions useMemo as a dependency
  • Removed header title useMemo

Bug:

Screen.Recording.2024-08-09.at.4.02.17.PM.mov

Fix:

Screen.Recording.2024-08-09.at.11.21.54.AM.mov

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 23, 2024 2:56am

Copy link
Contributor

github-actions bot commented Aug 9, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16429](https://github.com/binary-com/deriv-app/pull/16429)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-3521-fix-cashier-me-cc9817.binary.sx?qa_server=red.derivws.com&app_id=31528
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-3521-fix-cashier-me-cc9817.binary.sx
- **App ID**: `31528`

Copy link
Contributor

github-actions bot commented Aug 9, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-3521-fix-cashier-me-cc9817.binary.sx/

heorhi-deriv
heorhi-deriv previously approved these changes Aug 9, 2024
jim-deriv
jim-deriv previously approved these changes Aug 12, 2024
aizad-deriv
aizad-deriv previously approved these changes Aug 12, 2024
wojciech-deriv
wojciech-deriv previously approved these changes Aug 12, 2024
Copy link

vercel bot commented Aug 19, 2024

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@coveralls
Copy link

coveralls commented Aug 19, 2024

Coverage Status

coverage: 46.743% (+0.001%) from 46.742%
when pulling 8f64a95 on lubega-deriv:WALL-3521/fix-cashier-menu-translations
into 254a307 on binary-com:master.

Copy link

sonarcloud bot commented Aug 23, 2024

Copy link
Contributor

Generating Lighthouse report...

@jim-deriv jim-deriv merged commit 8537e31 into binary-com:master Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants