Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DTRA] Maryia/DTRA-1632/fix: Chart Scroll Behavior improvement for V2 #16434

Merged
merged 10 commits into from
Aug 29, 2024
Merged

[DTRA] Maryia/DTRA-1632/fix: Chart Scroll Behavior improvement for V2 #16434

merged 10 commits into from
Aug 29, 2024

Conversation

maryia-deriv
Copy link
Contributor

@maryia-deriv maryia-deriv commented Aug 12, 2024 •
edited
Loading

DTrader V2 Changes:

Chart Scroll Behavior improvement for V2.
Includes:

  • improving bottom nav styles
  • setting a fixed height for minimized trade params

Chart scroll behavior updates are done in this SmartCharts PR: deriv-com/SmartCharts#1628

@boring-cyborg boring-cyborg bot added the Trader label Aug 12, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 28, 2024 10:41am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 12, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/16434](https://github.com/binary-com/deriv-app/pull/16434)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryia-deriv-maryia-v2-chart-scroll.binary.sx?qa_server=red.derivws.com&app_id=24063
    - **Original**: https://deriv-app-git-fork-maryia-deriv-maryia-v2-chart-scroll.binary.sx
- **App ID**: `24063`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 12, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 32
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-maryia-deriv-maryia-v2-chart-scroll.binary.sx/

@coveralls
Copy link

coveralls commented Aug 12, 2024 •
edited
Loading

Coverage Status

coverage: 46.667% (-0.001%) from 46.668%
when pulling b93113a on maryia-deriv:maryia/v2-chart-scroll
into 2c6fb94 on binary-com:master.

@maryia-deriv
Copy link
Contributor Author

tests are failing on master

@maryia-deriv maryia-deriv mentioned this pull request Aug 15, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

⏳ Generating Lighthouse report...

@balakrishna-deriv balakrishna-deriv merged commit 540748a into binary-com:master Aug 29, 2024
8 checks passed
shahzaib-deriv pushed a commit that referenced this pull request Aug 29, 2024
@maryia-deriv @shahzaib-deriv
[DTRA] Maryia/DTRA-1632/fix: Chart Scroll Behavior improvement for V2 (…
71f8ee5 
…#16434)

* fix: improve bottom nav styles + add fixed height to trade params minimized

* fix: badge styling

* chore: remove unused important
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balakrishna-deriv balakrishna-deriv balakrishna-deriv approved these changes

@kate-deriv kate-deriv kate-deriv approved these changes

@ahmadtaimoor-deriv ahmadtaimoor-deriv ahmadtaimoor-deriv approved these changes

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

Assignees
No one assigned
Labels
Trader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maryia-deriv @coveralls @balakrishna-deriv @kate-deriv @ahmadtaimoor-deriv