Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DTRA] henry/dtra-1645/remove-extra-and-invalid-contractsfor-calls-trader-v2 #16506

Conversation

henry-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 20, 2024 10:09am

Copy link
Contributor

github-actions bot commented Aug 15, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16506](https://github.com/binary-com/deriv-app/pull/16506)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-henry-deriv-henry-dtra-1645remove-ext-0e2443.binary.sx?qa_server=red.derivws.com&app_id=24048
    - **Original**: https://deriv-app-git-fork-henry-deriv-henry-dtra-1645remove-ext-0e2443.binary.sx
- **App ID**: `24048`

Copy link
Contributor

github-actions bot commented Aug 15, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-henry-deriv-henry-dtra-1645remove-ext-0e2443.binary.sx/

@coveralls
Copy link

coveralls commented Aug 15, 2024

Coverage Status

coverage: 46.794% (+0.5%) from 46.262%
when pulling 66ee57e on henry-deriv:henry/dtra-1645/remove-extra-and-invalid-contractsfor-calls
into 6a4e828 on binary-com:master.

vinu-deriv
vinu-deriv previously approved these changes Aug 19, 2024
maryia-deriv
maryia-deriv previously approved these changes Aug 20, 2024
Copy link

sonarcloud bot commented Aug 20, 2024

@vinu-deriv vinu-deriv merged commit 778a079 into binary-com:master Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants