Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suisin/chore: remove mongolian language #16513

Conversation

suisin-deriv
Copy link
Contributor

Changes:

Remove mongolian language from production.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 27, 2024 7:11am

@coveralls
Copy link

coveralls commented Aug 15, 2024

Coverage Status

coverage: 46.903% (+0.04%) from 46.864%
when pulling 13b5a29 on suisin-deriv:suisin/UPM1376/remove_mongolian_language
into 59f5842 on binary-com:master.

Copy link
Contributor

github-actions bot commented Aug 15, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16513](https://github.com/binary-com/deriv-app/pull/16513)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-upm1376removemong-164709.binary.sx?qa_server=red.derivws.com&app_id=23836
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-upm1376removemong-164709.binary.sx
- **App ID**: `23836`

Copy link
Contributor

github-actions bot commented Aug 15, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-upm1376removemong-164709.binary.sx/

amina-deriv
amina-deriv previously approved these changes Aug 15, 2024
Copy link

sonarcloud bot commented Aug 27, 2024

Copy link
Contributor

Generating Lighthouse report...

@suisin-deriv
Copy link
Contributor Author

LGTM 😎

@amina-deriv amina-deriv merged commit 983975a into binary-com:master Aug 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants