Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOT] Farabi/bot-2155/faq-accordion-not-scrolling-into-content-view #16550

Conversation

farabi-deriv
Copy link
Contributor

@farabi-deriv farabi-deriv commented Aug 20, 2024

Changes:

  • Fixed scroll into view upon clicking and expanding FAQ accordion on desktop and mobile
  • Updated the test cases for faq-content file

Screenshots:

Screenshot 2024-08-27 at 7 39 24 PM

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 27, 2024 0:06am

Copy link
Contributor

github-actions bot commented Aug 20, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16550](https://github.com/binary-com/deriv-app/pull/16550)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-1504test-cove-6b391a.binary.sx?qa_server=red.derivws.com&app_id=24104
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-1504test-cove-6b391a.binary.sx
- **App ID**: `24104`

Copy link
Contributor

github-actions bot commented Aug 20, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-bot-1504test-cove-6b391a.binary.sx/

@coveralls
Copy link

coveralls commented Aug 20, 2024

Coverage Status

coverage: 47.007% (+0.1%) from 46.89%
when pulling f8794ae on farabi-deriv:farabi/bot-1504/test-coverage-for-tutorials-faq
into 1adce55 on binary-com:master.

@farabi-deriv farabi-deriv changed the title [BOT] Farabi/bot-1504/test-coverage-for-tutorials-faq [BOT] Farabi/bot-2155/faq-accordion-not-scrolling-into-content-view Aug 26, 2024
rupato-deriv
rupato-deriv previously approved these changes Aug 26, 2024
Copy link

sonarcloud bot commented Aug 27, 2024

Copy link
Contributor

github-actions bot commented Aug 27, 2024

Generating Lighthouse report...

@farabi-deriv farabi-deriv merged commit a7b12be into binary-com:master Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants