Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-4410 / Remove fiat text from transfer messages #16551

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Remove 'fiat' text from crypto to fiat transfer messages

Screenshots:

Please provide some screenshots of the change.
Screenshot 2024-08-20 at 3 33 04 PM
Screenshot 2024-08-20 at 3 41 05 PM

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 20, 2024 8:21am

Copy link

sonarcloud bot commented Aug 20, 2024

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16551](https://github.com/binary-com/deriv-app/pull/16551)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-4410-remove-fiat-fr-2d5deb.binary.sx?qa_server=red.derivws.com&app_id=30371
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-4410-remove-fiat-fr-2d5deb.binary.sx
- **App ID**: `30371`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-4410-remove-fiat-fr-2d5deb.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 46.265% (+0.003%) from 46.262%
when pulling 6f484b2 on lubega-deriv:WALL-4410/remove-fiat-from-transfer-messages
into 6a4e828 on binary-com:master.

@heorhi-deriv heorhi-deriv merged commit f9e1cae into binary-com:master Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants