Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-4689 / Replace wallets action screen with deriv-com/ui #16568

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Replace WalletsActionScreen with deriv-com/ui ActionScreen
  • Remove WalletsActionScreen component
  • Updated unit tests of related components

Screenshots:

image

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 2, 2024 8:27am

Copy link
Contributor

github-actions bot commented Aug 21, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16568](https://github.com/binary-com/deriv-app/pull/16568)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-4689-replace-wallet-65bba9.binary.sx?qa_server=red.derivws.com&app_id=24218
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-4689-replace-wallet-65bba9.binary.sx
- **App ID**: `24218`

Copy link
Contributor

github-actions bot commented Aug 21, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-4689-replace-wallet-65bba9.binary.sx/

@coveralls
Copy link

coveralls commented Aug 21, 2024

Coverage Status

coverage: 47.024% (+0.03%) from 46.99%
when pulling ab768df on lubega-deriv:WALL-4689/replace-wallets-action-screen
into b7504e6 on binary-com:master.

aizad-deriv
aizad-deriv previously approved these changes Aug 22, 2024
jim-deriv
jim-deriv previously approved these changes Aug 22, 2024
aizad-deriv
aizad-deriv previously approved these changes Aug 22, 2024
jim-deriv
jim-deriv previously approved these changes Aug 22, 2024
wojciech-deriv
wojciech-deriv previously approved these changes Aug 30, 2024
heorhi-deriv
heorhi-deriv previously approved these changes Aug 30, 2024
heorhi-deriv
heorhi-deriv previously approved these changes Aug 30, 2024
jim-deriv
jim-deriv previously approved these changes Sep 2, 2024
aizad-deriv
aizad-deriv previously approved these changes Sep 2, 2024
Copy link

sonarcloud bot commented Sep 2, 2024

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Generating Lighthouse report...

@jim-deriv jim-deriv merged commit 4e85ba5 into binary-com:master Sep 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants