Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CFDS] CFDS-4278/shontzu/Overlapping-in-reset-investor-password-modal #16604

Conversation

shontzu-deriv
Copy link
Contributor

@shontzu-deriv shontzu-deriv commented Aug 26, 2024

Changes:

  • Reset MT5 Password should not open Investor Password modal
  • Reset Investor Password should not open MT5 Password modal
  • Reset MT5 Password and Investor Password should be smooth in both appstore and account/password
  • Navigating between tradershub and account/passwords should not cause modal issue (i.e. reopening the modal)

Screenshots:

Before:

change_mt5_password.mp4

After:

Screen.Recording.2024-08-27.at.12.35.41.PM.mov

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 27, 2024 5:04am

@shontzu-deriv shontzu-deriv changed the title [CFDS] CFDS-4278/dhontzu/Overlapping-in-reset-investor-password-modal [CFDS] CFDS-4278/shontzu/Overlapping-in-reset-investor-password-modal Aug 26, 2024
Copy link
Contributor

github-actions bot commented Aug 26, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16604](https://github.com/binary-com/deriv-app/pull/16604)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shontzu-deriv-cfds-4278-dhontzuoverla-29da25.binary.sx?qa_server=red.derivws.com&app_id=31584
    - **Original**: https://deriv-app-git-fork-shontzu-deriv-cfds-4278-dhontzuoverla-29da25.binary.sx
- **App ID**: `31584`

Copy link
Contributor

github-actions bot commented Aug 26, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 39
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-cfds-4278-dhontzuoverla-29da25.binary.sx/

@coveralls
Copy link

coveralls commented Aug 26, 2024

Coverage Status

coverage: 46.862% (-0.002%) from 46.864%
when pulling 5f18ac9 on shontzu-deriv:CFDS-4278/dhontzu/Overlapping-in-reset-investor-password-modal
into 59f5842 on binary-com:master.

farrah-deriv
farrah-deriv previously approved these changes Aug 26, 2024
Copy link

sonarcloud bot commented Aug 27, 2024

@farrah-deriv farrah-deriv merged commit 1d27d6e into binary-com:master Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants