Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOT] sandeep/bot-2144/ server-bot fix: 🔥 fixed digits contract bot error #16630

Conversation

sandeep-deriv
Copy link
Contributor

Changes:

Fixed Error shown upon running contract with Match/Differ purchase condition.
"Error: Missing required contract parameters (last digit prediction for digit contracts). (code: ContractCreationFailure)" shown

Screenshots:

NA

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 28, 2024 4:04am

Copy link
Contributor

github-actions bot commented Aug 27, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16630](https://github.com/binary-com/deriv-app/pull/16630)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sandeep-deriv-sandeep-bot-2144server-6d92b4.binary.sx?qa_server=red.derivws.com&app_id=32205
    - **Original**: https://deriv-app-git-fork-sandeep-deriv-sandeep-bot-2144server-6d92b4.binary.sx
- **App ID**: `32205`

Copy link
Contributor

github-actions bot commented Aug 27, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 38
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-sandeep-deriv-sandeep-bot-2144server-6d92b4.binary.sx/

@coveralls
Copy link

coveralls commented Aug 27, 2024

Coverage Status

coverage: 47.034% (+0.06%) from 46.976%
when pulling d0cf5a8 on sandeep-deriv:sandeep/bot-2144/server-bot-matches-differ-fix
into 99dbb38 on binary-com:master.

rupato-deriv
rupato-deriv previously approved these changes Aug 28, 2024
Copy link

sonarcloud bot commented Aug 28, 2024

Copy link
Contributor

Generating Lighthouse report...

@sandeep-deriv sandeep-deriv merged commit 2af6df4 into binary-com:master Aug 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants