Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aizad/WALL-2948/Unit test for CreatePassword #16635

Conversation

aizad-deriv
Copy link
Contributor

Changes:

  • Create test case for CreatePassword component
  • Change import useDevice from internal package to deriv-com/ui

Screenshots:

image

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 28, 2024 4:26am

Copy link
Contributor

github-actions bot commented Aug 28, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16635](https://github.com/binary-com/deriv-app/pull/16635)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-2948unit-test-2ef845.binary.sx?qa_server=red.derivws.com&app_id=32877
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-2948unit-test-2ef845.binary.sx
- **App ID**: `32877`

Copy link
Contributor

github-actions bot commented Aug 28, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 40
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-wall-2948unit-test-2ef845.binary.sx/

@coveralls
Copy link

coveralls commented Aug 28, 2024

Coverage Status

coverage: 47.072% (+0.07%) from 47.005%
when pulling 5394a15 on aizad-deriv:aizad/WALL-2948/unit-test-create-password
into bd86a31 on binary-com:master.

Copy link

sonarcloud bot commented Aug 28, 2024

Copy link
Contributor

Generating Lighthouse report...

@heorhi-deriv heorhi-deriv merged commit aa38a39 into binary-com:master Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants