Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Aizad/WALL-2950/Unit test for EnterPassword #16664

Conversation

aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Aug 29, 2024

Changes:

  • Implement unit test for EnterPassword component

Screenshots:

image

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 29, 2024 7:54am

Copy link
Contributor

github-actions bot commented Aug 29, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16664](https://github.com/binary-com/deriv-app/pull/16664)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-2950unit-test-efde1f.binary.sx?qa_server=red.derivws.com&app_id=24096
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-2950unit-test-efde1f.binary.sx
- **App ID**: `24096`

Copy link
Contributor

github-actions bot commented Aug 29, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-wall-2950unit-test-efde1f.binary.sx/

Copy link

sonarcloud bot commented Aug 29, 2024

@coveralls
Copy link

coveralls commented Aug 29, 2024

Coverage Status

coverage: 46.784% (+0.04%) from 46.745%
when pulling c2dba89 on aizad-deriv:aizad/WALL-2950/unit-test-enter-password
into 152b7a6 on binary-com:master.

Copy link
Contributor

Generating Lighthouse report...

Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim-deriv jim-deriv merged commit 84f10d5 into binary-com:master Aug 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants