DTRA-1893 / Kate / [DTrader-V2]: Improvements - Parameter for Rise/Fall in minimize view is scrollable vertically #16808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-1893tradeparamsuiissue.binary.sx/ |
kate-deriv
requested review from
matin-deriv and
maryia-deriv
as code owners
|
|
⏳ Generating Lighthouse report... |
henry-deriv
approved these changes
Sep 12, 2024
balakrishna-deriv
approved these changes
Sep 12, 2024
amina-deriv
pushed a commit
that referenced
this pull request
Sep 18, 2024
* aum / WALL-4881 / remove-deposit-pop-up-for-mf-clients-real-account-creation (#16811) * feat: hide one time deposit for mf clients in real account creation * chore: remove unused variables * chore: fix test cases * chore: re-word the test case --------- Co-authored-by: nijil-deriv <nijil@deriv.com> * [WALL] Lubega / WALL-4842 / tUSDT notice banner and notification (#16786) * feat: tusdt notice banner and notification for wallets/th * fix: applied comments * fix: subtask * fix: subtask * fix: deposit crypto max width * [WALL] Lubega / WALL-2955 / MT5 trade screen unit test (#16807) * chore: mt5 trade screen unit test * chore: mt5 trade screen components unit test * [CFDS][WALL] shontzu/CFDS-4166/Improve-design-for-cTrader-and-dxtrade-Web-terminal-CTA-button (#16671) * chore: updated trade modal ui in TH and WALL * chore: remove unused imports * chore: remove remaining WalletButton components * fix: reset balance word misalignment (#16836) * DTRA-1893 / Kate / [DTrader-V2]: Improvements - Parameter for Rise/Fall in minimize view is scrollable vertically (#16808) * chore: add fixed height * refactor: remove unused files * refactor: remove more unused files * fix: add a fallback value (#16806) * [DTRA] Ahmad/DTRA-1705/Insufficient Balance And Not Logged in User Action Sheet (#16787) * chore: done * fix: fix * fix: test case * fix: adding in mockStore * chore: icon * chore: fix * fix: test case * fix: changing snakcase * chore: review comments * fix: review fix for signup * chore: fix * chore: fix * chore: one_time_deposit url param to trigger deposit modal if logged in (#16816) * [TRAH] Sergei / TRAH - 3858 / Blank screen shown for accounts with no currency (#16472) * feat: add check for currency * fix: add check for optional function from props * fix(core): 🚑 fix menulinks visibility (#16849) * [WALL] aum / WALL-4794 / resubmission-required-for-fully-authenticated-clients (#16720) * fix: resubmission for fully authenticated clients * fix: added check for previous attempt status * refactor: make is_poi_required code readable * Jim/wall 4348/replace wallet text with text from UI library (#16564) * chore: replace wallettext with text component * chore: revert back to previous type * chore: replace text with loader and add missed translations * chore: add translations * revert stylelint changes * chore: revert more stylelint changes * ci: fix failing tests * fix(wallets): 🚑 fix style issues (#16856) * fix: tooltip added for dashboard icons (#16827) * fix: upload strategy complete event on rudderstack (#16834) * translations: 📚 sync translations with crowdin (#16866) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * translations: 📚 sync translations with crowdin (#16868) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * [BOT]maryia/BOT-1981/feat: Add a "What's new" section to the dashboar… (#16577) * [BOT]maryia/BOT-1981/feat: Add a "What's new" section to the dashboard to promote Accumulators (#16369) * feat: announcement components * refactor: announcement config, make accounce dialog reusable * feat: make redirect and show block accumulator * feat: show indicator updated upon clicking on announcements * refactor: separate an announcement component * feat: add saving to local storage, refactor the code * chore: fix sonarcloud issues * chore: fix sonarcloud issues(2) * chore: fix sonarcloud issues(3) * feat: redirect to default strategy with accumulator upon clicking "try now" button * feat: redirect to default strategy with accumulator upon clicking "try now" button * refactor: click on announce button * feat: add video for accumulator feature on tutorial page * chore: simplify access to the context of the DOM element * test: announcement component * test: announcement-dialog component * test: announcements component * chore: add cursor for the button * chore: remove temporary other announcements except of accumulator feature * refactor: styles and remove unused import * chore: use global colors * chore: rename names of the tests * chore: change colors as per global colors * refactor: minor things * chore: remove UserGuide component and test * chore: remove dependency * chore: add @deriv/quill-icons to package.json * chore: replace .then() to await waitFor * chore: remove some code * chore: change color to global color that support dark and light mode * chore: refactor implementation, rename variables * refactor: announcements component, configs and helper functions * fix: sonar cloud issues * fix: test cases * fix: The icon and texts are not aligned as per design * fix: The cta size is different compared to design * fix: text indent * refactor: announcement-dialog * fix: styles announcement-dialog * style: improve * refactor: improvement accourding to comments (#16603) * feat: adapt Notifications component (#16608) * refactor: improvement accourding to comments * feat: adapt Notifications component * chore: rename prop of notifications * chore: rename prop of notifications (#16658) * chore: renaming child of content from content to content_item * chore: split .notifications_wrapper as per SASS convention * chore: make the same everywhere React.useState( way * chore: rename stored_notifications to read_announcements_map * chore: rename temp_data to updated_local_storage_data * chore: rename getButtonAction to performButtonAction * chore: update the version of deriv-com/ui * fix: the issue after update the version in dtrader * fix: provide the notifications component with new mandatory prop loadMoreFunction * chore: package-lock.json * chore: update version of deriv-com/ui * fix: remove loadMoreFunction prop * refactor: method to calc amount active announce, state for it * chore: add wrapper arrow function for handleRedirect method * fix: Unable to see the pop up on tab view * chore: add missed dependency, add eslint comments * fix: modal width on tablet * refactor: improve styles as per design on mobile version * chore: update the date for accumulator announce * chore: merge master(part2) * fix: server side pdf fix (#16810) * fix: server side pdf fix * fix: code smell * fix: code smell * fix: switch case * fix: snake case --------- Co-authored-by: Aum Bhatt <125039206+aum-deriv@users.noreply.github.com> Co-authored-by: nijil-deriv <nijil@deriv.com> Co-authored-by: lubega-deriv <142860499+lubega-deriv@users.noreply.github.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: mayuran-deriv <129507167+mayuran-deriv@users.noreply.github.com> Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <fe-access@regentmarkets.com> Co-authored-by: maryia-matskevich-deriv <103181650+maryia-matskevich-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Chore changes
Screenshots: