Mahdi.aryayi / Fix design bugs #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negarn
reviewed
Oct 10, 2019
packages/trader/src/Modules/Account/Sections/Profile/PersonalDetails/personal-details.jsx
Outdated
Show resolved
Hide resolved
negarn
reviewed
Oct 10, 2019
packages/trader/src/Modules/Account/Sections/Profile/PersonalDetails/personal-details.jsx
Outdated
Show resolved
Hide resolved
negarn
reviewed
Oct 10, 2019
packages/trader/src/App/Components/Elements/SideMenu/side-menu-headers.jsx
Show resolved
Hide resolved
packages/trader/src/Modules/Account/Sections/Profile/PersonalDetails/personal-details.jsx
Outdated
Show resolved
Hide resolved
packages/trader/src/Modules/Account/Sections/Profile/PersonalDetails/personal-details.jsx
Outdated
Show resolved
Hide resolved
mahdiaryayi-fs
force-pushed
the
fix-design-bugs
branch
from
4761016
to
a0401e3
Compare
packages/trader/src/Modules/Account/Sections/Profile/PersonalDetails/personal-details.jsx
Outdated
Show resolved
Hide resolved
mahdiaryayi-fs
force-pushed
the
fix-design-bugs
branch
from
3337d42
to
90bed41
Compare
|
@mahdiaryayi-fs travis failing |
| className='account-form__footer-btn btn--primary--default' | ||
| className={classNames('account-form__footer-btn', { | ||
| 'btn--primary--default': !is_submit_success, | ||
| 'btn--primary--green' : is_submit_success, |
There was a problem hiding this comment.
@mahdiaryayi-fs ahh just one more suggestion: could you make this changes in the <Button /> component itself? this should be applied to all usages of Button, not only on this page 😄
There was a problem hiding this comment.
@kelly-binary I checked <Button /> use cases in deriv trader. The component is style agnostic. We are passing different classNames in different cases. If I add this logic by adding btn--primary--default and btn--primary--green inside <Button />, it doesn't work in other places that we are not using primary button classes and it may cause styling conflict.
mahdiaryayi-fs
force-pushed
the
fix-design-bugs
branch
from
4a9dded
to
90f6370
Compare
negarn
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix design bugs