Adrienne / Changed layout for PM cards list in Ads page #5284
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| import React from 'react'; | ||
| import { useStores } from 'Stores'; | ||
| import { ThemedScrollbars } from '@deriv/components'; | ||
| import { isMobile } from '@deriv/shared'; | ||
| import { observer } from 'mobx-react-lite'; | ||
| import { localize } from 'Components/i18next'; | ||
| import PropTypes from 'prop-types'; | ||
| import classNames from 'classnames'; | ||
| import PaymentMethodCard from '../my-profile/payment-methods/payment-method-card'; | ||
| import './sell-ad-payment-methods-list.scss'; | ||
|
|
||
| const SellAdPaymentMethodsList = ({ | ||
| is_only_horizontal = isMobile(), | ||
| is_scrollable = isMobile(), | ||
| onClickAdd, | ||
| onClickPaymentMethodCard, | ||
| selected_methods, | ||
| }) => { | ||
| const { my_profile_store } = useStores(); | ||
|
|
||
| const style = { | ||
| borderColor: 'var(--brand-secondary)', | ||
| borderWidth: '2px', | ||
| }; | ||
|
|
||
| // payment method order: Bank Transfer -> EWallets -> Others | ||
| const payment_method_order = { bank_transfer: 0, other: 2 }; | ||
| const getPaymentMethodOrder = method => (!(method in payment_method_order) ? 1 : payment_method_order[method]); | ||
| const sortPaymentMethods = payment_methods_list => { | ||
| return payment_methods_list.sort((i, j) => getPaymentMethodOrder(i.method) - getPaymentMethodOrder(j.method)); | ||
| }; | ||
|
|
||
| return ( | ||
| <ThemedScrollbars | ||
| className={classNames('sell-ad-payment-methods__container', { | ||
| 'sell-ad-payment-methods__container--horizontal': is_only_horizontal, | ||
| })} | ||
| is_scrollbar_hidden | ||
| is_scrollable={is_scrollable} | ||
| is_only_horizontal={is_only_horizontal} | ||
| > | ||
| {sortPaymentMethods([...my_profile_store.advertiser_payment_methods_list]).map((payment_method, key) => ( | ||
| <PaymentMethodCard | ||
|
There was a problem hiding this comment. Sorted payment methods list in order as per QA requirements |
||
| is_vertical_ellipsis_visible={false} | ||
| key={key} | ||
| medium | ||
| onClick={() => onClickPaymentMethodCard(payment_method)} | ||
| payment_method={payment_method} | ||
| style={selected_methods.includes(payment_method.ID) ? style : {}} | ||
| /> | ||
| ))} | ||
| <PaymentMethodCard is_add label={localize('Payment method')} medium onClickAdd={onClickAdd} /> | ||
| </ThemedScrollbars> | ||
| ); | ||
| }; | ||
|
|
||
| SellAdPaymentMethodsList.propTypes = { | ||
| is_only_horizontal: PropTypes.bool, | ||
| is_scrollable: PropTypes.bool, | ||
| onClickAdd: PropTypes.func, | ||
| onClickPaymentMethodCard: PropTypes.func, | ||
| selected_methods: PropTypes.array, | ||
| }; | ||
|
|
||
| export default observer(SellAdPaymentMethodsList); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| .sell-ad-payment-methods { | ||
| &__container { | ||
| display: grid; | ||
| grid-template-columns: repeat(4, 0.19fr); | ||
|
|
||
| &--horizontal { | ||
| grid-auto-flow: column; | ||
| & .payment-method-card { | ||
| margin: 1rem 1.5rem 1rem auto; | ||
| } | ||
|
|
||
| & .payment-method-card--add { | ||
| margin: 1rem 1.5rem 1rem 0; | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
margin-bottom: 7.5remas it is a bug added in previous PR which will be fixed in card Task #64742