Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bala/regenerate package lock #5851

Merged

Conversation

balakrishna-deriv
Copy link
Contributor

Changes:

Regenerate package lock

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Jun 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Jun 30, 2022 at 4:53AM (UTC)

yashim-deriv
yashim-deriv previously approved these changes Jun 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/5851](https://github.com/binary-com/deriv-app/pull/5851)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-balakrishna-binary-regenerate-package-lock.binary.sx?qa_server=frontend.binaryws.com&app_id=24087
    - **Original**: https://deriv-app-git-fork-balakrishna-binary-regenerate-package-lock.binary.sx
- **App ID**: `24087`

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #5851 (1aadeae) into master (31e35ee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5851   +/-   ##
=======================================
  Coverage   21.74%   21.74%           
=======================================
  Files        1289     1289           
  Lines       29285    29285           
  Branches     4941     4941           
=======================================
  Hits         6367     6367           
  Misses      22562    22562           
  Partials      356      356           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e35ee...1aadeae. Read the comment docs.

@carolsachdeva carolsachdeva merged commit 4fd234b into binary-com:master Jun 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants