Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bala/fix failing test case #5878

Merged

Conversation

balakrishna-deriv
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jun 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Jun 30, 2022 at 11:04AM (UTC)

Copy link
Contributor

@maryia-deriv maryia-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Member

@ali-hosseini-deriv ali-hosseini-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/5878](https://github.com/binary-com/deriv-app/pull/5878)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-balakrishna-binary-fix-failing-test-case.binary.sx?qa_server=frontend.binaryws.com&app_id=23854
    - **Original**: https://deriv-app-git-fork-balakrishna-binary-fix-failing-test-case.binary.sx
- **App ID**: `23854`

@codecov-commenter
Copy link

Codecov Report

Merging #5878 (0251ba8) into master (3d8078e) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #5878      +/-   ##
==========================================
- Coverage   21.72%   21.71%   -0.01%     
==========================================
  Files        1292     1292              
  Lines       29312    29333      +21     
  Branches     4943     4945       +2     
==========================================
+ Hits         6367     6371       +4     
- Misses      22589    22605      +16     
- Partials      356      357       +1     
Impacted Files Coverage Δ
...ges/cfd/src/Containers/cfd-dashboard-container.tsx 0.00% <0.00%> (ø)
packages/cfd/src/Containers/cfd-dashboard.tsx 0.00% <ø> (ø)
packages/cfd/src/Stores/Modules/CFD/cfd-store.js 0.00% <0.00%> (ø)
packages/core/src/Stores/client-store.js 9.63% <0.00%> (-0.02%) ⬇️
packages/cfd/src/Helpers/constants.ts 46.66% <50.00%> (+3.80%) ⬆️
packages/core/src/_common/base/socket_base.js 50.00% <50.00%> (ø)
packages/cfd/src/Components/cfd-account-card.tsx 84.69% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9487490...0251ba8. Read the comment docs.

@balakrishna-deriv balakrishna-deriv merged commit 9c390cb into binary-com:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants