Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ako/ Small change to update the components cache in NX cloud #6743

Conversation

ali-hosseini-deriv
Copy link
Member

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Oct 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 6:18AM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.2% 4.2% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/6743](https://github.com/binary-com/deriv-app/pull/6743)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ali-hosseini-fs-ako-small-change-to-u-cca3e1.binary.sx?qa_server=frontend.binaryws.com&app_id=24093
    - **Original**: https://deriv-app-git-fork-ali-hosseini-fs-ako-small-change-to-u-cca3e1.binary.sx
- **App ID**: `24093`

@codecov-commenter
Copy link

Codecov Report

Merging #6743 (473722b) into master (6149b32) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6743   +/-   ##
=======================================
  Coverage   22.14%   22.14%           
=======================================
  Files        1438     1438           
  Lines       32607    32607           
  Branches     5512     5512           
=======================================
  Hits         7221     7221           
  Misses      24919    24919           
  Partials      467      467           
Impacted Files Coverage Δ
...es/components/src/components/app-card/app-card.jsx 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@farrah-deriv farrah-deriv merged commit 781bec0 into binary-com:master Oct 12, 2022
adrienne-deriv pushed a commit to adrienne-deriv/deriv-app that referenced this pull request Oct 20, 2022
adrienne-deriv pushed a commit to adrienne-deriv/deriv-app that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants