Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thisyahlen/ add total assets #6754

Merged
merged 8 commits into from
Oct 17, 2022

Conversation

thisyahlen-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Oct 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Oct 17, 2022 at 8:54AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/6754](https://github.com/binary-com/deriv-app/pull/6754)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-totalassets.binary.sx?qa_server=frontend.binaryws.com&app_id=23847
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-totalassets.binary.sx
- **App ID**: `23847`

@boring-cyborg boring-cyborg bot added the Core label Oct 14, 2022
@thisyahlen-deriv thisyahlen-deriv changed the title thisyahlen/ add title and total assets thisyahlen/ add total assets Oct 17, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (pre-appstore@8dfff4d). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             pre-appstore    #6754   +/-   ##
===============================================
  Coverage                ?   21.25%           
===============================================
  Files                   ?     1532           
  Lines                   ?    34110           
  Branches                ?     5964           
===============================================
  Hits                    ?     7249           
  Misses                  ?    26381           
  Partials                ?      480           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mahdiyeh-deriv mahdiyeh-deriv merged commit 8102a8c into binary-com:pre-appstore Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants