Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vinu/78411/replace connect account transfer #6791

Conversation

vinu-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Replaced connect with observer in account-transfer related pages

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Nov 11, 2022 at 7:20AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/6791](https://github.com/binary-com/deriv-app/pull/6791)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-vinu-deriv-vinu-78411replace-connect-199465.binary.sx?qa_server=frontend.binaryws.com&app_id=32114
    - **Original**: https://deriv-app-git-fork-vinu-deriv-vinu-78411replace-connect-199465.binary.sx
- **App ID**: `32114`

@vinu-deriv vinu-deriv marked this pull request as ready for review October 20, 2022 14:16
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@3bee68b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #6791   +/-   ##
==========================================
  Coverage           ?   21.75%           
==========================================
  Files              ?     1436           
  Lines              ?    33153           
  Branches           ?     5706           
==========================================
  Hits               ?     7212           
  Misses             ?    25473           
  Partials           ?      468           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

… account_transfer in account-transfer component
@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@farrah-deriv farrah-deriv merged commit 418ba43 into binary-com:develop Nov 11, 2022
adrienne-deriv pushed a commit to adrienne-deriv/deriv-app that referenced this pull request Nov 17, 2022
* remove commit form account transfer WIP

* refactor: replaced connect with observer in account-transfer related pages

* refactor: ♻️ removed repeated code in account-transfer-receipt.spec file

* refactored/implemented review comments in account-transfer related test files

* refactor: 🎨 implemented review comments, transfer locked added inside account_transfer in account-transfer component

* fixed sidenotes type in account-transfer-form
adrienne-deriv pushed a commit to adrienne-deriv/deriv-app that referenced this pull request Nov 17, 2022
* remove commit form account transfer WIP

* refactor: replaced connect with observer in account-transfer related pages

* refactor: ♻️ removed repeated code in account-transfer-receipt.spec file

* refactored/implemented review comments in account-transfer related test files

* refactor: 🎨 implemented review comments, transfer locked added inside account_transfer in account-transfer component

* fixed sidenotes type in account-transfer-form
adrienne-deriv pushed a commit to adrienne-deriv/deriv-app that referenced this pull request Nov 17, 2022
* remove commit form account transfer WIP

* refactor: replaced connect with observer in account-transfer related pages

* refactor: ♻️ removed repeated code in account-transfer-receipt.spec file

* refactored/implemented review comments in account-transfer related test files

* refactor: 🎨 implemented review comments, transfer locked added inside account_transfer in account-transfer component

* fixed sidenotes type in account-transfer-form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants