Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suisin/Create connected-app article #6801

Conversation

suisin-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 4:20AM (UTC)

suisin-deriv and others added 2 commits October 21, 2022 17:19
…_article_at_connected_apps_page_on_app_deriv
…79192/to_add_infobox_related_to_API_article_at_connected_apps_page_on_app_deriv
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/6801](https://github.com/binary-com/deriv-app/pull/6801)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-79192toaddinfobox-6ec262.binary.sx?qa_server=frontend.binaryws.com&app_id=23851
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-79192toaddinfobox-6ec262.binary.sx
- **App ID**: `23851`

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Merging #6801 (3b3c692) into master (db902d5) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master    #6801   +/-   ##
=======================================
  Coverage   21.74%   21.75%           
=======================================
  Files        1438     1439    +1     
  Lines       33164    33169    +5     
  Branches     5704     5705    +1     
=======================================
+ Hits         7213     7217    +4     
- Misses      25483    25484    +1     
  Partials      468      468           
Impacted Files Coverage Δ
...Sections/Security/ConnectedApps/connected-apps.jsx 77.50% <66.66%> (+0.57%) ⬆️
.../Security/ConnectedApps/connected-apps-article.jsx 75.00% <75.00%> (ø)
...ackages/account/src/Components/article/article.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

suisin-deriv and others added 3 commits October 28, 2022 10:33
…79192/to_add_infobox_related_to_API_article_at_connected_apps_page_on_app_deriv
…onnected_apps_page_on_app_deriv' of github.com:suisin-deriv/deriv-app into suisin/79192/to_add_infobox_related_to_API_article_at_connected_apps_page_on_app_deriv
…_article_at_connected_apps_page_on_app_deriv
…_article_at_connected_apps_page_on_app_deriv
…_article_at_connected_apps_page_on_app_deriv
suisin-deriv and others added 2 commits November 9, 2022 11:38
…onnected_apps_page_on_app_deriv' of github.com:suisin-deriv/deriv-app into suisin/79192/to_add_infobox_related_to_API_article_at_connected_apps_page_on_app_deriv
…_article_at_connected_apps_page_on_app_deriv
…_article_at_connected_apps_page_on_app_deriv
…_article_at_connected_apps_page_on_app_deriv
amina-deriv
amina-deriv previously approved these changes Nov 9, 2022
mahdiyeh-deriv
mahdiyeh-deriv previously approved these changes Nov 9, 2022
…79192/to_add_infobox_related_to_API_article_at_connected_apps_page_on_app_deriv
…onnected_apps_page_on_app_deriv' of github.com:suisin-deriv/deriv-app into suisin/79192/to_add_infobox_related_to_API_article_at_connected_apps_page_on_app_deriv
mahdiyeh-deriv
mahdiyeh-deriv previously approved these changes Nov 14, 2022
amina-deriv
amina-deriv previously approved these changes Nov 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@carolsachdeva carolsachdeva changed the base branch from master to develop November 17, 2022 07:26
@carolsachdeva carolsachdeva merged commit e566d94 into binary-com:develop Nov 17, 2022
adrienne-deriv pushed a commit to adrienne-deriv/deriv-app that referenced this pull request Dec 7, 2022
* Create connected-app article

* update Title

* remove infobox when it is in loading screen

* fix: change title to include ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants