george / rm78412 / repalce connect in withdrawal page #6809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heorhi-deriv
requested review from
nijil-deriv,
balakrishna-deriv and
matin-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
…thub.com/george-usynin-binary/deriv-app into 78412_repalce-connect-in-withdrawal-page
|
Kudos, SonarCloud Quality Gate passed!
|
hamid-deriv
reviewed
Oct 26, 2022
| is_virtual: false, | ||
| verification_code: '', | ||
| verify_error: {}, | ||
| let history, mockRootStore, setSideNotes; |
| requestWithdraw: jest.fn(), | ||
| setBlockchainAddress: jest.fn(), | ||
| setWithdrawPercentageSelectorResult: jest.fn(), | ||
| let mockRootStore; |
There was a problem hiding this comment.
Suggested change
| let mockRootStore; | |
| let mockRootStore: DeepPartial<TRootStore>; |
| setIsWithdrawConfirmed: jest.fn(), | ||
| resetWithrawForm: jest.fn(), | ||
| setIsCryptoTransactionsVisible: jest.fn(), | ||
| let mockRootStore; |
There was a problem hiding this comment.
Suggested change
| let mockRootStore; | |
| let mockRootStore: DeepPartial<TRootStore>; |
farzin-deriv
approved these changes
Oct 27, 2022
bahar-sadeghzadeh
approved these changes
Oct 27, 2022
adrienne-deriv
pushed a commit
to adrienne-deriv/deriv-app
that referenced
this pull request
Nov 17, 2022
* refactor(withdraw): replace connect in crypto-withdraw-form, fix tests * refactor(withdraw): repace connect in crypto-withdraw-receipt, fix tests * refactor(withdraw): replace connect in wirhdraw, fix tests * refactor(withdraw): replace connect in withdrawal-locked, fix tests * refactor(withdraw): replace connect into withdrawal-verification-email, fix tests * refactor(withdraw): replace connect into withdrawal, fix tests * test(withdraw): refactor withdrawal-locked test * fix(side-note): fix side_notes type * fix(error types): fix error types * test(withdraw): improve withdrawal test * refactor(error types): refactor error types * trigger build
adrienne-deriv
pushed a commit
to adrienne-deriv/deriv-app
that referenced
this pull request
Nov 17, 2022
* refactor(withdraw): replace connect in crypto-withdraw-form, fix tests * refactor(withdraw): repace connect in crypto-withdraw-receipt, fix tests * refactor(withdraw): replace connect in wirhdraw, fix tests * refactor(withdraw): replace connect in withdrawal-locked, fix tests * refactor(withdraw): replace connect into withdrawal-verification-email, fix tests * refactor(withdraw): replace connect into withdrawal, fix tests * test(withdraw): refactor withdrawal-locked test * fix(side-note): fix side_notes type * fix(error types): fix error types * test(withdraw): improve withdrawal test * refactor(error types): refactor error types * trigger build
adrienne-deriv
pushed a commit
to adrienne-deriv/deriv-app
that referenced
this pull request
Nov 17, 2022
* refactor(withdraw): replace connect in crypto-withdraw-form, fix tests * refactor(withdraw): repace connect in crypto-withdraw-receipt, fix tests * refactor(withdraw): replace connect in wirhdraw, fix tests * refactor(withdraw): replace connect in withdrawal-locked, fix tests * refactor(withdraw): replace connect into withdrawal-verification-email, fix tests * refactor(withdraw): replace connect into withdrawal, fix tests * test(withdraw): refactor withdrawal-locked test * fix(side-note): fix side_notes type * fix(error types): fix error types * test(withdraw): improve withdrawal test * refactor(error types): refactor error types * trigger build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change