Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

farrah/72116/fixed loading of payment details #6847

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

farrah-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the P2P label Nov 3, 2022
@vercel
Copy link

vercel bot commented Nov 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Nov 7, 2022 at 8:11AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/6847](https://github.com/binary-com/deriv-app/pull/6847)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farrah-deriv-pm-details.binary.sx?qa_server=frontend.binaryws.com&app_id=31229
    - **Original**: https://deriv-app-git-fork-farrah-deriv-pm-details.binary.sx
- **App ID**: `31229`

@farrah-deriv farrah-deriv marked this pull request as ready for review November 7, 2022 08:03
@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

Copy link
Contributor

@ameerul-deriv ameerul-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farrah-deriv farrah-deriv changed the base branch from master to develop November 15, 2022 07:37
@farrah-deriv farrah-deriv merged commit 5033f3c into binary-com:develop Nov 15, 2022
adrienne-deriv pushed a commit to adrienne-deriv/deriv-app that referenced this pull request Nov 17, 2022
adrienne-deriv pushed a commit to adrienne-deriv/deriv-app that referenced this pull request Nov 17, 2022
adrienne-deriv pushed a commit to adrienne-deriv/deriv-app that referenced this pull request Nov 17, 2022
adrienne-deriv pushed a commit to adrienne-deriv/deriv-app that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants