Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vinu/79411/derivez cashier transfer #6896

Merged

Conversation

vinu-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Derivez added in transfer when entering cashier from deriv-go

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Nov 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Nov 24, 2022 at 6:13AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/6896](https://github.com/binary-com/deriv-app/pull/6896)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-vinu-deriv-vinu-79411derivez-cashier-da39c7.binary.sx?qa_server=frontend.binaryws.com&app_id=30371
    - **Original**: https://deriv-app-git-fork-vinu-deriv-vinu-79411derivez-cashier-da39c7.binary.sx
- **App ID**: `30371`

@vinu-deriv vinu-deriv marked this pull request as ready for review November 14, 2022 11:57
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #6896 (4b2d57c) into develop (477c30b) will increase coverage by 0.38%.
The diff coverage is 33.83%.

❗ Current head 4b2d57c differs from pull request most recent head d51149d. Consider uploading reports for the commit d51149d to get more accurate results

@@             Coverage Diff             @@
##           develop    #6896      +/-   ##
===========================================
+ Coverage    21.49%   21.87%   +0.38%     
===========================================
  Files         1450     1441       -9     
  Lines        33655    33191     -464     
  Branches      5878     5730     -148     
===========================================
+ Hits          7234     7261      +27     
+ Misses       25949    25456     -493     
- Partials       472      474       +2     
Impacted Files Coverage Δ
packages/account/src/Constants/routes-config.js 0.00% <0.00%> (ø)
packages/account/src/Containers/account.jsx 0.00% <0.00%> (ø)
...c/components/cashier-container/virtual/virtual.tsx 66.66% <ø> (+8.33%) ⬆️
...ount-transfer-receipt/account-transfer-receipt.tsx 87.09% <0.00%> (-6.01%) ⬇️
packages/cfd/build/constants.js 0.00% <0.00%> (ø)
packages/cfd/build/webpack.config.js 0.00% <ø> (ø)
packages/cfd/src/Components/cfd-account-card.tsx 80.31% <ø> (ø)
...es/cfd/src/Components/cfd-demo-account-display.tsx 87.87% <ø> (ø)
...rc/Components/cfd-dxtrade-demo-account-display.tsx 42.85% <ø> (ø)
...fd/src/Components/cfd-mt5-demo-account-display.tsx 46.66% <ø> (ø)
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

hamid-deriv
hamid-deriv previously approved these changes Nov 14, 2022
farzin-deriv
farzin-deriv previously approved these changes Nov 15, 2022
heorhi-deriv
heorhi-deriv previously approved these changes Nov 21, 2022
nijil-deriv
nijil-deriv previously approved these changes Nov 21, 2022
hamid-deriv
hamid-deriv previously approved these changes Nov 21, 2022
hamid-deriv
hamid-deriv previously approved these changes Nov 22, 2022
heorhi-deriv
heorhi-deriv previously approved these changes Nov 22, 2022
nijil-deriv
nijil-deriv previously approved these changes Nov 23, 2022
heorhi-deriv
heorhi-deriv previously approved these changes Nov 23, 2022
farzin-deriv
farzin-deriv previously approved these changes Nov 23, 2022
hamid-deriv
hamid-deriv previously approved these changes Nov 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@farrah-deriv farrah-deriv merged commit 5d9c943 into binary-com:develop Nov 29, 2022
carolsachdeva pushed a commit to carolsachdeva/deriv-app that referenced this pull request Dec 13, 2022
carolsachdeva added a commit that referenced this pull request Dec 13, 2022
carolsachdeva added a commit that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants