Adrienne / Show online offline status in advertiser page #6913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine-status-advertiser
…vertiser' of github.com:adrienne-deriv/deriv-app into adrienne-deriv/task-79700/show-online-offline-status-advertiser
…ertiser-info-subscription
adrienne-deriv
requested review from
carolsachdeva and
nijil-deriv
as code owners
farrah-deriv
previously approved these changes
Nov 17, 2022
nijil-deriv
reviewed
Nov 17, 2022
packages/p2p/src/components/online-status/online-status-label.jsx
Outdated
Show resolved
Hide resolved
nijil-deriv
previously approved these changes
Nov 17, 2022
…ine-status-advertiser-with-subs
carol/Add comment
…ine-status-advertiser-with-subs
…ine-status-advertiser-with-subs
|
Kudos, SonarCloud Quality Gate passed!
|
vinu-deriv
pushed a commit
to vinu-deriv/deriv-app
that referenced
this pull request
Nov 24, 2022
…6913) * remove p2p_advertiser_info call from buy-sell-store * remove p2p_advertiser_info call from my-profile-store * remove p2p_advertiser_info call from my-ads-store * remove available balance hook * remove p2p_advertiser_info call from order-store * make p2p_advertiser_info in advertiser_page_store a subscription * cleanup * Added online status to advertiser page * Removed unused css * remove unnecessary action.bound * added more padding in rating row * fix: review comments * cleanup advertiser page store * cleanup buy-sell- store * cleanup my-ads-store * cleanup my-profile-store * cleanup order-store * Fixed styling issues * fix subtask * fix subtask * updated changes * Refactored code with subs * Refactored code with subs * Reverted icons.js * Refactored icons.js * Refactored code based on reviews * Refactored code based on reviews * Refactored online status label * Refactored code * Refactored code * Fixed CircleCI issue * Refactored code * Used advertiser details id to check if its my advert * used moment shared functions * Refactored label * Update online-status-label.jsx * Update online-status-label.jsx * docs: add comment * Added checks for years and months greater than 6 * Fixed typo Co-authored-by: Carol Sachdeva <carol@binary.com> Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com>
adrienne-deriv
added a commit
to adrienne-deriv/deriv-app
that referenced
this pull request
Dec 7, 2022
…6913) * remove p2p_advertiser_info call from buy-sell-store * remove p2p_advertiser_info call from my-profile-store * remove p2p_advertiser_info call from my-ads-store * remove available balance hook * remove p2p_advertiser_info call from order-store * make p2p_advertiser_info in advertiser_page_store a subscription * cleanup * Added online status to advertiser page * Removed unused css * remove unnecessary action.bound * added more padding in rating row * fix: review comments * cleanup advertiser page store * cleanup buy-sell- store * cleanup my-ads-store * cleanup my-profile-store * cleanup order-store * Fixed styling issues * fix subtask * fix subtask * updated changes * Refactored code with subs * Refactored code with subs * Reverted icons.js * Refactored icons.js * Refactored code based on reviews * Refactored code based on reviews * Refactored online status label * Refactored code * Refactored code * Fixed CircleCI issue * Refactored code * Used advertiser details id to check if its my advert * used moment shared functions * Refactored label * Update online-status-label.jsx * Update online-status-label.jsx * docs: add comment * Added checks for years and months greater than 6 * Fixed typo Co-authored-by: Carol Sachdeva <carol@binary.com> Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change