-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Farzin/85472/R&D/Remove CashierStore
initialization from core package
#7278
Merged
farrah-deriv
merged 51 commits into
binary-com:develop
from
farzin-deriv:farzin/84619/r&d/remove_cashierstore_initialization_from_core_package
Jan 27, 2023
Merged
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
7babd01
refactor(cashier): :fire: remove `mobx-react-lite` from `cashier`
32b4c73
refactor(cashier): :recycle: replace `connect` with `useStore` for re…
73c5b25
refactor(cashier): :recycle: fix test files to use `StoreProvider`
d33218b
refactor(cashier): :fire: remove `connect` from `cashier`
df76fc2
refactor(cashier): :fire: remove extra store related types from `cash…
02f8cfe
fix(stores): :bug: stop persisting the stores when store is unmount
00a5fbd
Merge branch 'develop' into farzin/76562/remove_legacy_connect_method…
631cc10
Merge branch 'develop' into farzin/76562/remove_legacy_connect_method…
745f900
Merge branch 'develop' into farzin/76562/remove_legacy_connect_method…
5ec3d1d
feat(cashier): :sparkles: add `useCashierStore` hook
2849fb3
refactor(cashier): :recycle: replace `modules.cashier` with `useCashi…
665f908
refactor(cashier): :recycle: remove `useStore` hook return type override
5d932cd
Merge branch 'develop' into farzin/84619/r&d/remove_cashierstore_init…
633767c
Merge branch 'develop' into farzin/84619/r&d/remove_cashierstore_init…
8eb9dcb
Merge branch 'develop' into farzin/84619/r&d/remove_cashierstore_init…
20858f1
fix(cashier): :memo: resolve PR conflicts
b9fbbbd
Merge branch 'develop' into farzin/84619/r&d/remove_cashierstore_init…
600f9c0
Merge branch 'develop' into farzin/84619/r&d/remove_cashierstore_init…
35bbcca
Merge branch 'develop' into farzin/84619/r&d/remove_cashierstore_init…
286f8fd
test(cashier): :white_check_mark: fix the tests
2c3b80c
chore(cashier): :truck: rename `cashier_providers.tsx` to `cashier-pr…
e512bc8
Shayan/52349/react17 migration (#6908)
shayan-deriv 5c2a910
test(cashier): :white_check_mark: fix the tests
c0b38f4
Merge branch 'develop' into farzin/84619/r&d/remove_cashierstore_init…
dd129b7
test(cashier): :white_check_mark: fix the tests
cfbbf1b
fix: add optional chaining in getMinDuration function (#7344)
kate-deriv b6f7e4c
fix: :bug: resolved issue with trade. odal (#7291)
likhith-deriv 58990e0
feat(api): :technologist: improve `@deriv/api` typings
9891bc6
chore(cashier): :pencil2: fix React 17 type issue with `PropsWithChil…
d543da7
Merge branch 'master' of https://github.com/binary-com/deriv-app into…
farrah-deriv 637d467
Merge branch 'develop' into farzin/84619/r&d/remove_cashierstore_init…
49430b3
Revert "fix: :bug: resolved issue with trade. odal (#7291)" (#7364)
matin-deriv ab72826
Farzin/85054/Call `resetWithrawForm` on `CryptoWithdrawForm` componen…
farzin-deriv db321a8
Niloofar Sadeghi / Task - Refactor tests in the language.spec.js file…
niloofar-deriv 440892f
refactor: proposal tests (#7327)
niloofar-deriv 00a9dda
Niloofar Sadeghi / Task - Refactor tests in the error.spec.js file (#…
niloofar-deriv 492b437
Niloofar Sadeghi / Task - Refactor tests in the binary-link.spec.tsx …
niloofar-deriv eb59db8
refactor: money tests (#7353)
niloofar-deriv 325d629
refactor: toggle-positions tests (#7287)
niloofar-deriv 4c3f477
refactor: toggle-button tests (#7328)
niloofar-deriv 906c784
Niloofar Sadeghi / Task - Refactor tests in the toggle-button-group.s…
niloofar-deriv 2a71abf
refactor: open-positions-table tests (#7374)
niloofar-deriv 1f93b8d
Niloofar Sadeghi / Task - Refactor tests in the marker-spot-label.spe…
niloofar-deriv ebce045
Niloofar Sadeghi / Task - Refactor tests in the binary-link.spec.tsx …
niloofar-deriv ccbad43
Niloofar Sadeghi / Task - Refactor tests in the contract-type-dialog.…
niloofar-deriv 311feec
Niloofar Sadeghi / Task - Refactor tests in the platform-dropdown.spe…
niloofar-deriv c2336d4
Merge branch 'develop' into farzin/84619/r&d/remove_cashierstore_init…
9cc73c5
Merge branch 'develop' into farzin/84619/r&d/remove_cashierstore_init…
4793939
Merge branch 'develop' into farzin/84619/r&d/remove_cashierstore_init…
4f714d4
Merge branch 'develop' into farzin/84619/r&d/remove_cashierstore_init…
1dd45bb
Merge branch 'develop' into farzin/84619/r&d/remove_cashierstore_init…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import React from 'react'; | ||
import { StoreProvider } from '@deriv/stores'; | ||
import { CashierStoreProvider } from './stores/useCashierStores'; | ||
import { TRootStore } from './types/stores'; | ||
|
||
const CashierProviders = ({ children, store }: React.PropsWithChildren<{ store: TRootStore }>) => { | ||
return ( | ||
<StoreProvider store={store}> | ||
<CashierStoreProvider>{children}</CashierStoreProvider> | ||
</StoreProvider> | ||
); | ||
}; | ||
|
||
export default CashierProviders; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just made a small improvement on the types, Now if all of the parameters for an endpoint are optional TS won’t complain that you need to pass an argument anymore, It will be optional to pass params.