Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amina/86159/vanuatu on derived #7523

Merged
merged 628 commits into from
Mar 17, 2023
Merged

Amina/86159/vanuatu on derived #7523

merged 628 commits into from
Mar 17, 2023

Conversation

amina-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

amina-deriv and others added 30 commits January 13, 2023 14:47
@amina-deriv
fix: mt5 dashboard fix
2dfc7c8
@amina-deriv
fix: test cases
146078f
@amina-deriv
fix: test case
6ab713c
@hirad-deriv
Merge branch 'feature/82781/diel_for_all' of github.com:matin-binary/…
3fefc0d 
…deriv-app into feature/diel
@hirad-deriv
fix: fixed the alignment issue of password-selection-modal
c22409d
@amina-deriv
fix: switching on exit traders modal
0e7ce52
@jim-deriv
chore: show appropriate information on the account switcher in the ol…
a0eb8fe 
…d UI
@matin-deriv
Merge pull request binary-com#136 from amina-deriv/85843_mt5_dashboar…
7494ab3 
…d_fix

Amina/ fix: mt5 dashboard fix
@matin-deriv
Merge pull request binary-com#140 from jim-deriv/JIm/85885/account-sw…
c02de11 
…itcher-for-low-risk-cr-clients-in-the-old-design-displays-wrong-info

JIm/85885/account-switcher-for-low-risk-cr-clients-in-the-old-design-displays-wrong-info
@matin-deriv
Merge pull request binary-com#138 from hirad-rewok/Hirad/85886/select…
7a9782d 
…-password-modal-alignment

Hirad/85886/Select password modal alignment
@amina-deriv
fix: next button disabled in eu signup
e0aa789
@amina-deriv
fix: test case fix
0e8d2c7
@thisyahlen-deriv
fix: account switcher
ef5cc11
@thisyahlen-deriv
fix: manage account in account switcher
0f96133
@mahdiyeh-deriv
Merge pull request binary-com#142 from amina-deriv/amina_85847_next_b…
3c451d7 
…utton_disabled_eu_signup

Amina/fix: next button disabled in eu signup
@amina-deriv
fix: dxtrade error
08d85b4
@mahdiyeh-deriv
Merge pull request binary-com#143 from amina-deriv/amina_86116_fix_er…
462506c 
…ror_in_dxtrade

Amina 86116 fix error in dxtrade
fix: redirecting for traders_hub
98fd90b
Merge branch 'feature/82781/diel_for_all' of github.com:matin-deriv/d…
2299f2d 
…eriv-app into feature/82781/diel_for_all
@jim-deriv
Merge branch 'feature/82781/diel_for_all' of github.com:matin-deriv/d…
b0dee9d 
…eriv-app
@jim-deriv
Merge branch 'feature/82781/diel_for_all' of github.com:matin-deriv/d…
0f50632 
…eriv-app
@mahdiyeh-deriv
Merge pull request binary-com#144 from jim-deriv/Jim/86155/resolve-co…
c340f5b 
…nflicts

Jim/86155/resolve conflicts
@hirad-deriv
Merge branch 'feature/82781/diel_for_all' of github.com:matin-binary/…
f662127 
…deriv-app into feature/diel
@mahdiyeh-deriv
Merge pull request binary-com#139 from amina-deriv/85888-switch-to-no…
471c07c 
…n-eu-on-exiting-traders-hub

Amina/fix: switching on exit traders modal
@hirad-deriv
Merge branch 'feature/82781/diel_for_all' of github.com:matin-binary/…
7495284 
…deriv-app into feature/diel
fix: header traders hub cursor pointer
dca915a
@hirad-deriv
Merge branch 'feature/82781/diel_for_all' of github.com:matin-binary/…
dc5e3fc 
…deriv-app into feature/diel
@amina-deriv
fix: acc switcher
78fff7d
@hirad-deriv
fix: fixing issues of the tour guide
c330b58
@matin-deriv
Merge pull request binary-com#145 from amina-deriv/amina_86188_accoun…
6c3fe69 
…t_switcher_issue

Amina/fix: acc switcher
likhith-deriv
likhith-deriv previously approved these changes Feb 10, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

suisin-deriv
suisin-deriv approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@suisin-deriv suisin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bahar-sadeghzadeh bahar-sadeghzadeh merged commit dc59a0c into binary-com:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhith-deriv likhith-deriv likhith-deriv approved these changes

@suisin-deriv suisin-deriv suisin-deriv approved these changes

@matin-deriv matin-deriv matin-deriv left review comments

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv

Assignees
No one assigned
Labels
Account AppStore Core Shared
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.