bahar/87991/fix: transfer_to_cashier_error #7547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bahar-sadeghzadeh
changed the title
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-bahar-deriv-fixtransfertocashiererror.binary.sx/ |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #7547 +/- ##
=======================================
Coverage 19.93% 19.93%
=======================================
Files 1497 1497
Lines 35196 35196
Branches 6449 6449
=======================================
Hits 7018 7018
Misses 27610 27610
Partials 568 568 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
farzin-deriv
approved these changes
Feb 8, 2023
mahdiyeh-deriv
approved these changes
Feb 8, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
⏳ Generating Lighthouse report... |
sergei-deriv
pushed a commit
to sergei-deriv/deriv-app
that referenced
this pull request
Feb 14, 2023
aizad-deriv
pushed a commit
to aizad-deriv/deriv-app
that referenced
this pull request
Feb 15, 2023
mahdiyeh-deriv
pushed a commit
that referenced
this pull request
Feb 15, 2023
…ier (#7515) * fix: close transfer modal after click deposit button * fix: transfer popup appeared when enter to traders hub * feat: empty * fix: close modal right * refactor: prettier refactor * refactor: delete some types * fix: close transfer modal after click deposit button * fix: transfer popup appeared when enter to traders hub * feat: empty * fix: close modal right * fix: close transfer modal in cleanup function * chore: empty * fix: transfer_to_cashier_error (#7547) * fix: close modal when try to deposit * feat: destructure props --------- Co-authored-by: Carol Sachdeva <carol@binary.com> Co-authored-by: Bahar <bahar@regentmarkets.com>
bahar-sadeghzadeh
pushed a commit
to bahar-sadeghzadeh/deriv-app
that referenced
this pull request
Feb 20, 2023
bahar-sadeghzadeh
pushed a commit
to bahar-sadeghzadeh/deriv-app
that referenced
this pull request
Feb 20, 2023
…ier (binary-com#7515) * fix: close transfer modal after click deposit button * fix: transfer popup appeared when enter to traders hub * feat: empty * fix: close modal right * refactor: prettier refactor * refactor: delete some types * fix: close transfer modal after click deposit button * fix: transfer popup appeared when enter to traders hub * feat: empty * fix: close modal right * fix: close transfer modal in cleanup function * chore: empty * fix: transfer_to_cashier_error (binary-com#7547) * fix: close modal when try to deposit * feat: destructure props --------- Co-authored-by: Carol Sachdeva <carol@binary.com> Co-authored-by: Bahar <bahar@regentmarkets.com>
shontzu-deriv
added a commit
to shontzu-deriv/deriv-app
that referenced
this pull request
Feb 21, 2023
This reverts commit 50f384b.
bahar-sadeghzadeh
pushed a commit
that referenced
this pull request
Apr 28, 2023
* fix: initializing * fix: added the necessary icons * fix: rebranding of traders-hub and onboarding * fix: changed deriv logo in header * fix: made changes according to recommendations * fix: changed cfds and modals icons * fix: added new icons for menu * fix: fixing the prop types error * Revert "fix: transfer_to_cashier_error (#7547)" This reverts commit 50f384b. * fix: cleaner rebranding attempt * fix: trader hub header logo * fix: dark mode in traders hub * fix: made logo size in headers consistent * fix: revert link_to back to href in platform-config that broke the navigation * fix: remove unnecesary code in platform-config * fix: one line * fix: changed icon naming for dark and light mode and added PropTypes to components * refactor: update the color using var keyword in the svg file to automatically support both colors * fix: invisible icon text, use currentColor instead of var in svg * revert: reverted last 2 commits that cause icon issues * fix: testing the branch * fix: removed the redundant smart trader * fix: replacing the redundant icons * fix: fixed all of the issues with rebranding icons * fix: removed the duplicate icons * fix: removed dark mode icons and used one icon for both light and dark mode * fix: fixed the circle ci issues * fix: change D initials to Deriv and swap colors for real and demo in traderhub dropdown * refactor: change the wallet balance color based on account type(demo/real) * refactor: removed unused code * fix: made changes based on reviews * refactor: removed unnecesary !important property * fix: made changes according to the recommendations * refactor: fixed dark mode handling for icons * fix: removed all of the redundant icons * fix: removed the redundant test case * fix: made changes to dxtrade icon * revert: reverted the test case for dark mode that was deleted * fix: changed the color of cross icon in the onboarding page * fix: pulled from main branch and rebuilt project * fix: remove unused is_dark_mode props * fix: remove mock connect store and props from test cases * fix: fixed the code smell related to the cashier provider store * fix: removed deriv-apps redundant icon * fix: added description tags in icons for screenreader * refactor: refactor based on review * refactor: added comments on the purpose of the <desc> tag * fix: forgot to change prop name * fix: minified one icon * fix: remove unnecesary curly braces * Round-up patches based on review refactor: added comments on the purpose of the <desc> tag fix: forgot to change prop name fix: minified one icon fix: remove unnecesary curly braces * fix: fix wrong colors in demo and real * fix: fixed the alignment issue if deriv logo in traders-hub dashboard * fix: update deriv icon in footer * fix: update DerivX icon * fix: added new icons to transfer page of cashier * fix: udpate test cases * fix: remove redundatnt test case * fix: change account_type to all in test case * fix: increased the floatPrecision of svg-loader * fix: changed the icon of cashier transfer page for derivx * fix: fix unit test in cfd-download-container * feat: new branding for email and passwords page * fix: update favicon * fix: updated favicons in core * fix: updated favicons in trader and cfd packages * fix: remove -copy suffix from icon names * revert: revert to old DerivX icon for non-tradershub pages * fix: fixed the white line issue of icons by adding the new ones * revert: undo favicon changes in cfd and trader packages * fix: fixed the icon size of deriv logo in trader's hub * fix: alignment of deriv logo in onboarding page * remove comment * style: use rem instead of % * fix: update derivx logo in cashier page and trade modal * fix: derivx icon in trade terminal * fix: localize icon description * fix: deriv logo alignment in onboarding page * fix: fixed aliasing in smarttrader and binarybot icons * fix: aliased icons in email-and-passwords page * fix: options icon dark and light mode * fix: derivx logo in trade modal, transfer modal, and cashier * fix: minify icon * fix: scaled down deriv logo in onboarding page * fix: made latest changes for rebranding * fix: finishing the improvement cards for rebranding * fix: changed font colors * fix: added the demo content to our label * fix: removed the demo from deriv platforms * fix: replaced account type and currency in the currency switcher --------- Co-authored-by: shontzu-deriv <shon.tzu@regentmarkets.com> Co-authored-by: Hirad <hirad@Hirads-MacBook-Pro.local> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change