fix: fixed redirection back to dp2p #7609

nada-deriv · 2023-02-15T11:47:49Z

Changes:

Please include a summary of the change and which issue is fixed below:
Fixed redirection issue onclick backtop2p button after poi submission

...

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

vercel · 2023-02-15T11:47:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 24, 2023 11:13am

github-actions · 2023-02-15T11:59:46Z

A production App ID was automatically generated for this PR. (log)

PR: fix: fixed redirection back to dp2p #7609
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-nada-deriv-nada-88485back-to-p2p-fix.binary.sx?qa_server=red.binaryws.com&app_id=23926
- Original: https://deriv-app-git-fork-nada-deriv-nada-88485back-to-p2p-fix.binary.sx
App ID: 23926

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/7609](https://github.com/binary-com/deriv-app/pull/7609)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nada-deriv-nada-88485back-to-p2p-fix.binary.sx?qa_server=red.binaryws.com&app_id=23926
    - **Original**: https://deriv-app-git-fork-nada-deriv-nada-88485back-to-p2p-fix.binary.sx
- **App ID**: `23926`

github-actions · 2023-02-15T12:00:11Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	18
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-88485back-to-p2p-fix.binary.sx/

codecov-commenter · 2023-02-15T12:12:01Z

Codecov Report

Merging #7609 (e8bd136) into master (678b7ef) will increase coverage by 0.06%.
The diff coverage is 4.34%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #7609      +/-   ##
==========================================
+ Coverage   20.72%   20.78%   +0.06%     
==========================================
  Files        1538     1553      +15     
  Lines       35945    36057     +112     
  Branches     7031     7058      +27     
==========================================
+ Hits         7449     7495      +46     
- Misses      27750    27823      +73     
+ Partials      746      739       -7

Impacted Files	Coverage Δ
...status/idv-submit-complete/idv-submit-complete.tsx	`100.00% <ø> (ø)`
...tion/ProofOfAddress/proof-of-address-container.jsx	`0.00% <0.00%> (ø)`
...on/ProofOfIdentity/proof-of-identity-container.jsx	`0.00% <0.00%> (ø)`
packages/core/src/Stores/common-store.js	`0.00% <0.00%> (ø)`
...s/p2p/src/components/verification/verification.jsx	`52.00% <0.00%> (-20.23%)`	⬇️
packages/shared/src/utils/platform/platform.ts	`14.13% <50.00%> (+0.58%)`	⬆️

... and 54 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

niloofar-deriv · 2023-02-15T12:14:52Z

packages/account/src/Sections/Verification/ProofOfIdentity/proof-of-identity-container.jsx

+            className='proof-of-identity__redirect'
+            onClick={() => {
+                if (platforms[from_platform.name?.toLowerCase()].is_hard_redirect) {
+                    window.location.href = platforms[from_platform.name?.toLowerCase()].url;


This pattern may cause security issues, please change it like this 🙏

Suggested change

window.location.href = platforms[from_platform.name?.toLowerCase()].url;

const url = platforms[from_platform.name?.toLowerCase()].url;

window.location.href = url;

More details: https://codeql.github.com/codeql-query-help/javascript/js-xss-through-dom/

niloofar-deriv

LGTM 👍

adrienne-deriv

LGTM

The base branch was changed.

ameerul-deriv

LGTM

niloofar-deriv

LGTM

sonarcloud · 2023-04-24T11:07:50Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2023-04-24T11:23:05Z

⏳ Generating Lighthouse report...

fix: fixed redirection back to dp2p

947eda5

nada-deriv requested a review from yashim-deriv as a code owner February 15, 2023 11:47

boring-cyborg bot added the Account label Feb 15, 2023

vercel bot deployed to Preview February 15, 2023 11:59 View deployment

niloofar-deriv reviewed Feb 15, 2023

View reviewed changes

fix: pr comment resolved

58b5008

vercel bot deployed to Preview February 15, 2023 13:07 View deployment

niloofar-deriv previously approved these changes Feb 15, 2023

View reviewed changes

adrienne-deriv previously approved these changes Feb 16, 2023

View reviewed changes

ameerul-deriv previously approved these changes Feb 21, 2023

View reviewed changes

fix: merged with latest develop

b17d512

boring-cyborg bot added the P2P label Feb 23, 2023

vercel bot deployed to Preview February 23, 2023 09:30 View deployment

nada-deriv changed the base branch from develop to master March 8, 2023 09:38

fix: updated with latest master

0274eb7

vercel bot deployed to Preview March 8, 2023 09:48 View deployment

fix: merged with latest master

d4ce66e

vercel bot deployed to Preview March 16, 2023 04:47 View deployment

fix: show button for idv poi submission

4406c28

vercel bot deployed to Preview March 16, 2023 12:47 View deployment

fix: pr comment fix

de0a0c9

vercel bot deployed to Preview March 16, 2023 13:57 View deployment

fix: pr comment fix

7c5d279

vercel bot deployed to Preview March 22, 2023 12:02 View deployment

niloofar-deriv previously approved these changes Mar 22, 2023

View reviewed changes

fix: merge conflicts resolved

4754102

nada-deriv dismissed niloofar-deriv’s stale review via 4754102 April 3, 2023 07:29

vercel bot deployed to Preview April 3, 2023 07:38 View deployment

ameerul-deriv previously approved these changes Apr 3, 2023

View reviewed changes

niloofar-deriv previously approved these changes Apr 3, 2023

View reviewed changes

farhan-nurzi-deriv previously approved these changes Apr 4, 2023

View reviewed changes

nada-deriv added 3 commits April 7, 2023 08:45

fix: merge with master

83a1bf5

fix: updated with latest master

a4611a1

fix: check for p2p using platform param

49b7cf9

nada-deriv dismissed stale reviews from farhan-nurzi-deriv, niloofar-deriv, and ameerul-deriv via 49b7cf9 April 18, 2023 07:29

boring-cyborg bot added the Shared label Apr 18, 2023

vercel bot deployed to Preview April 18, 2023 07:41 View deployment

fix: removed unused function

1e9a998

vercel bot deployed to Preview April 18, 2023 08:03 View deployment

farrah-deriv previously approved these changes Apr 18, 2023

View reviewed changes

farhan-nurzi-deriv previously approved these changes Apr 18, 2023

View reviewed changes

fix: changed param checking from p2p to dp2p

0d6a836

nada-deriv dismissed stale reviews from farhan-nurzi-deriv and farrah-deriv via 0d6a836 April 24, 2023 09:20

vercel bot deployed to Preview April 24, 2023 09:33 View deployment

fix: persist local storage value until cleared

e8bd136

boring-cyborg bot added the Core label Apr 24, 2023

vercel bot deployed to Preview April 24, 2023 11:13 View deployment

amina-deriv merged commit e4b2c0c into binary-com:master May 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fixed redirection back to dp2p #7609

fix: fixed redirection back to dp2p #7609

nada-deriv commented Feb 15, 2023

vercel bot commented Feb 15, 2023 •

edited

Loading

github-actions bot commented Feb 15, 2023 •

edited

Loading

github-actions bot commented Feb 15, 2023 •

edited

Loading

codecov-commenter commented Feb 15, 2023 •

edited

Loading

niloofar-deriv Feb 15, 2023

niloofar-deriv Feb 15, 2023

nada-deriv Feb 15, 2023

niloofar-deriv left a comment

adrienne-deriv left a comment

ameerul-deriv left a comment

niloofar-deriv left a comment

sonarcloud bot commented Apr 24, 2023

github-actions bot commented Apr 24, 2023

	window.location.href = platforms[from_platform.name?.toLowerCase()].url;
	const url = platforms[from_platform.name?.toLowerCase()].url;
	window.location.href = url;

fix: fixed redirection back to dp2p #7609

fix: fixed redirection back to dp2p #7609

Conversation

nada-deriv commented Feb 15, 2023

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

vercel bot commented Feb 15, 2023 • edited Loading

github-actions bot commented Feb 15, 2023 • edited Loading

github-actions bot commented Feb 15, 2023 • edited Loading

codecov-commenter commented Feb 15, 2023 • edited Loading

Codecov Report

niloofar-deriv Feb 15, 2023

Choose a reason for hiding this comment

niloofar-deriv Feb 15, 2023

Choose a reason for hiding this comment

nada-deriv Feb 15, 2023

Choose a reason for hiding this comment

niloofar-deriv left a comment

Choose a reason for hiding this comment

adrienne-deriv left a comment

Choose a reason for hiding this comment

ameerul-deriv left a comment

Choose a reason for hiding this comment

niloofar-deriv left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Apr 24, 2023

github-actions bot commented Apr 24, 2023

vercel bot commented Feb 15, 2023 •

edited

Loading

github-actions bot commented Feb 15, 2023 •

edited

Loading

github-actions bot commented Feb 15, 2023 •

edited

Loading

codecov-commenter commented Feb 15, 2023 •

edited

Loading