-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
likhith/feat:incorporated string normalization to match non english characters #7649
Merged
carolsachdeva
merged 14 commits into
binary-com:master
from
likhith-deriv:likhith/88490/country-selection-for-non-english-language
Mar 1, 2023
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c870118
feat: :zap: incorporated string normalization to match non english ch…
likhith-deriv f65cd19
Merge branch 'master' into likhith/88490/country-selection-for-non-en…
matin-deriv e2d3ae4
fix: ensuring non english character match
likhith-deriv 9a42b99
feat: resolved import issue
likhith-deriv 002f281
feat: incorporated helper function
likhith-deriv b3a142a
feat: added testcases for helper function
likhith-deriv ac6e7e2
Merge branch 'master' into likhith/88490/country-selection-for-non-en…
likhith-deriv 23f849a
Merge branch 'master' into likhith/88490/country-selection-for-non-en…
likhith-deriv 14402c6
feat: incorporated helper function to all case
likhith-deriv 6ded026
feat: :art: refactored code
likhith-deriv a67f69d
feat: code refactor
likhith-deriv 67baab3
Merge branch 'master' into likhith/88490/country-selection-for-non-en…
likhith-deriv 3772143
Merge branch 'master' into likhith/88490/country-selection-for-non-en…
likhith-deriv b2c3b5d
Merge branch 'master' into likhith/88490/country-selection-for-non-en…
carolsachdeva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
const { getEnglishCharacters } = require('../helper'); | ||
|
||
describe('Utility/Helper', () => { | ||
it('should return english alphabets removing special characters', () => { | ||
const test_input = 'Ai Cập'; | ||
const test_result = 'Ai Cap'; | ||
|
||
expect(getEnglishCharacters(test_input)).toMatch(test_result); | ||
}); | ||
|
||
it('should return empty string if the text contains no english characters', () => { | ||
const test_input = '埃及'; | ||
const test_result = ''; | ||
|
||
expect(getEnglishCharacters(test_input)).toMatch(test_result); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt we add the or condtion when is_string_array is true. will this work?