Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 fixes the truncated cookie banner for non-en languages #7669

Merged
merged 15 commits into from
Feb 27, 2023
Merged

fix: 🐛 fixes the truncated cookie banner for non-en languages #7669

Changes from 4 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d23d454
fix: :bug: fixes the truncateed cookie banner for non-en langs
shaheer-deriv Feb 20, 2023
f24fb97
Merge branch 'master' into shaheer/88938/truncated-cookie-banner
shaheer-deriv Feb 21, 2023
02b2321
Merge branch 'master' into shaheer/88938/truncated-cookie-banner
shaheer-deriv Feb 21, 2023
48b766f
fix: :bug: fixes the text out of button bug in cookie banner
shaheer-deriv Feb 21, 2023
67c379c
Merge branch 'master' into shaheer/88938/truncated-cookie-banner
shaheer-deriv Feb 22, 2023
f8144a2
Merge branch 'master' into shaheer/88938/truncated-cookie-banner
shaheer-deriv Feb 22, 2023
14bdc5e
Merge branch 'master' into shaheer/88938/truncated-cookie-banner
shaheer-deriv Feb 22, 2023
9e502f6
Merge branch 'master' into shaheer/88938/truncated-cookie-banner
shaheer-deriv Feb 22, 2023
bf8c4a5
Merge branch 'master' into shaheer/88938/truncated-cookie-banner
shaheer-deriv Feb 23, 2023
45d0b43
Merge branch 'master' into shaheer/88938/truncated-cookie-banner
shaheer-deriv Feb 23, 2023
f596215
Merge branch 'master' into shaheer/88938/truncated-cookie-banner
shaheer-deriv Feb 23, 2023
8039244
Merge branch 'master' into shaheer/88938/truncated-cookie-banner
shaheer-deriv Feb 24, 2023
0360cb2
Merge branch 'master' into shaheer/88938/truncated-cookie-banner
shaheer-deriv Feb 24, 2023
0c1eecb
Merge branch 'master' into shaheer/88938/truncated-cookie-banner
jim-deriv Feb 27, 2023
010c13f
Merge branch 'master' into shaheer/88938/truncated-cookie-banner
jim-deriv Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/core/src/sass/app/_common/components/cookie-banner.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
padding: 2.8rem 0;
bottom: 0;
width: 100%;
height: 152px;
height: fit-content;
text-align: center;
transition: top 0.3s ease-in-out;
z-index: 1000;
Expand Down Expand Up @@ -46,7 +46,6 @@
&__btn-dont-accept:hover,
&__btn-accept,
&__btn-accept:hover {
display: inline-block;
margin: 20px auto 0;
height: 40px;
border-width: 2px;
Expand All @@ -63,10 +62,10 @@
}
&__btn-dont-accept,
&__btn-dont-accept:hover {
width: 116px;
width: fit-content;
margin-right: 8px;
}
&__btn-accept {
width: 78px;
width: fit-content;
}
}