-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ameerul /Task 77336 Error model content required when user tries to block an advertiser who is banned from P2P #7673
Ameerul /Task 77336 Error model content required when user tries to block an advertiser who is banned from P2P #7673
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-task-77336-error-model-ba8a78.binary.sx/ |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #7673 +/- ##
==========================================
- Coverage 20.81% 20.80% -0.02%
==========================================
Files 1561 1561
Lines 36117 36143 +26
Branches 7090 7101 +11
==========================================
Hits 7518 7518
- Misses 27857 27883 +26
Partials 742 742
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
011e868
to
dd96d61
Compare
dd96d61
to
8d0d0a2
Compare
…7336-error-model-content-required
The base branch was changed.
…336-error-model-content-required
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2bdf17b
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
⏳ Generating Lighthouse report... |
…lock an advertiser who is banned from P2P (binary-com#7673) * chore: refactored code based off modal manager and fixed string * chore: fixed logic to display modals * chore: fixed cashier locked issue * chore: refactored error message
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change