-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: removed individual POC calls made against contracts, added glob… #7707
perf: removed individual POC calls made against contracts, added glob… #7707
Conversation
…al POC subscription
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-sandeep-deriv-sandeep-88073improvemen-b74840.binary.sx/ |
…provement-proposal_open_contract-1
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #7707 +/- ##
=======================================
Coverage 20.73% 20.73%
=======================================
Files 1539 1539
Lines 35917 35917
Branches 7012 7012
=======================================
Hits 7447 7447
Misses 27750 27750
Partials 720 720 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The base branch was changed.
this.updateResultsCompletedContract(proposal_open_contract); | ||
} | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the user is on bot platform the core POC should not be called, it is causing duplicate calls.
…github.com:sandeep-deriv/deriv-app into sandeep/88073/improvement-proposal_open_contract-1
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
⏳ Generating Lighthouse report... |
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change