Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: removed individual POC calls made against contracts, added glob… #7707

Conversation

sandeep-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Removed individual proposal_open_contract calls against each contract
  • Added global proposal_open_contract subscription
  • Removed unnecessary forget calls for proposal since its not a subscription we don't need to forget it

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the Bot label Feb 22, 2023
@vercel
Copy link

vercel bot commented Feb 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2023 1:57am

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/7707](https://github.com/binary-com/deriv-app/pull/7707)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sandeep-deriv-sandeep-88073improvemen-b74840.binary.sx?qa_server=frontend.binaryws.com&app_id=32932
    - **Original**: https://deriv-app-git-fork-sandeep-deriv-sandeep-88073improvemen-b74840.binary.sx
- **App ID**: `32932`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-sandeep-deriv-sandeep-88073improvemen-b74840.binary.sx/

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #7707 (6d3b15b) into master (4163347) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #7707   +/-   ##
=======================================
  Coverage   20.73%   20.73%           
=======================================
  Files        1539     1539           
  Lines       35917    35917           
  Branches     7012     7012           
=======================================
  Hits         7447     7447           
  Misses      27750    27750           
  Partials      720      720           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

vinu-deriv
vinu-deriv previously approved these changes Feb 27, 2023
@sandeep-deriv sandeep-deriv changed the base branch from develop to master March 31, 2023 06:02
@sandeep-deriv sandeep-deriv dismissed stale reviews from vinu-deriv and balakrishna-deriv March 31, 2023 06:02

The base branch was changed.

this.updateResultsCompletedContract(proposal_open_contract);
}
});
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the user is on bot platform the core POC should not be called, it is causing duplicate calls.

…github.com:sandeep-deriv/deriv-app into sandeep/88073/improvement-proposal_open_contract-1
@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

Generating Lighthouse report...

@hamid-deriv hamid-deriv merged commit 5c28246 into binary-com:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants