Evgeniy / 89431 / no error message for idv duplicated document numbers

packages/account/src/Components/poi/idv-document-submit/__tests__/idv-document-submit.spec.js

@@ -6,9 +6,6 @@ import { isSequentialNumber, isRecurringNumberRegex } from '../utils';
 
 jest.mock('react-router');
 jest.mock('Assets/ic-document-submit-icon.svg', () => jest.fn(() => 'DocumentSubmitLogo'));
-jest.mock('../../../hooks/useToggleValidation', () => ({
-    useToggleValidation: jest.fn(() => '#toggle_id_validation'),
-}));
 jest.mock('../utils.js', () => ({
     getDocumentData: function (country_code, key) {
         const data = {
@@ -30,6 +27,7 @@ jest.mock('../utils.js', () => ({
     getRegex: jest.fn(() => /5436454364243/i),
     isSequentialNumber: jest.fn(() => false),
     isRecurringNumberRegex: jest.fn(() => false),
+    isIDVWhitelistDocumentNumber: jest.fn(() => false),
 }));
 
 jest.mock('@deriv/shared', () => ({

packages/account/src/Components/poi/idv-document-submit/idv-document-submit.jsx

@@ -1,5 +1,4 @@
 import React from 'react';
-import { useLocation } from 'react-router';
 import PropTypes from 'prop-types';
 import classNames from 'classnames';
 import { Autocomplete, Button, DesktopWrapper, Input, MobileWrapper, Text, SelectNative } from '@deriv/components';
@@ -13,15 +12,13 @@ import {
     isRecurringNumberRegex,
     isSequentialNumber,
     preventEmptyClipboardPaste,
+    isIDVWhitelistDocumentNumber,
 } from './utils';
-import { useToggleValidation } from '../../hooks/useToggleValidation';
 import FormFooter from 'Components/form-footer';
 import BackButtonIcon from 'Assets/ic-poi-back-btn.svg';
 import DocumentSubmitLogo from 'Assets/ic-document-submit-icon.svg';
 
 const IdvDocumentSubmit = ({ handleBack, handleViewComplete, selected_country, is_from_external }) => {
-    const location = useLocation();
-    const validation_is_enabled = useToggleValidation(location?.hash);
     const [document_list, setDocumentList] = React.useState([]);
     const [document_image, setDocumentImage] = React.useState(null);
     const [is_input_disable, setInputDisable] = React.useState(true);
@@ -118,6 +115,14 @@ const IdvDocumentSubmit = ({ handleBack, handleViewComplete, selected_country, i
         const is_sequential_number = isSequentialNumber(document_number);
         const is_recurring_number = isRecurringNumberRegex(document_number);
         const needs_additional_document = !!document_type.additional;
+        const is_idv_whitelist_document_number = isIDVWhitelistDocumentNumber(
+            country_code,
+            document_type.id,
+            document_number
+        );
+        const is_document_number_invalid =
+            (!is_idv_whitelist_document_number && (is_recurring_number || is_sequential_number)) ||
+            document_number === document_type.example_format;
 
         if (!document_type || !document_type.text || !document_type.value) {
             errors.document_type = localize('Please select a document type.');
@@ -135,10 +140,7 @@ const IdvDocumentSubmit = ({ handleBack, handleViewComplete, selected_country, i
         if (!document_number) {
             errors.document_number =
                 localize('Please enter your document number. ') + getExampleFormat(document_type.example_format);
-        } else if (
-            (validation_is_enabled && (is_recurring_number || is_sequential_number)) ||
-            document_number === document_type.example_format
-        ) {
+        } else if (is_document_number_invalid) {
             errors.document_number = localize('Please enter a valid ID number.');
         } else {
             const format_regex = getRegex(document_type.value);

packages/account/src/Components/poi/idv-document-submit/utils.js

@@ -1,4 +1,4 @@
-import { getUrlBase } from '@deriv/shared';
+import { getPlatformFromUrl, getUrlBase } from '@deriv/shared';
 
 const PATTERN_SIZE = 5;
 
@@ -48,6 +48,15 @@ export const isSequentialNumber = document_number => {
     return pattern_results.includes(true);
 };
 
+// function for skipping validation of exact document numbers for QA smileidentity sandbox testing
+export const isIDVWhitelistDocumentNumber = (country, document_type, document_number) => {
+    const is_whitelisted_number =
+        idv_test_document_whitelist.has(country) &&
+        idv_test_document_whitelist.get(country)[document_type] === document_number;
+
+    return is_whitelisted_number && (getPlatformFromUrl().is_test_link || getPlatformFromUrl().is_staging);
+};
+
 export const getRegex = target_regex => {
     const output_regex = regex.find(r => r.regex_string === target_regex);
     if (output_regex) {
@@ -203,3 +212,10 @@ const idv_document_data = {
         },
     },
 };
+
+export const idv_test_document_whitelist = new Map([
+    ['gh', { drivers_license: 'B0000000', passport: 'G0000000', ssnit: 'C000000000000', voter_id: '0000000000' }],
+    ['ke', { alien_card: '000000', passport: 'A00000000', national_id: '00000000' }],
+    ['ng', { drivers_license: 'ABC000000000', nin_slip: '00000000000', voter_id: '0000000000000000000' }],
+    ['za', { national_id: '0000000000000', national_id_no_photo: '0000000000000' }],
+]);

packages/account/src/Components/poi/poi-form-on-signup/idv-doc-submit-on-signup/idv-doc-submit-on-signup.jsx

@@ -1,5 +1,4 @@
 import React from 'react';
-import { useLocation } from 'react-router';
 import { Formik, Field } from 'formik';
 import { localize, Localize } from '@deriv/translations';
 import {
@@ -22,13 +21,11 @@ import {
     isRecurringNumberRegex,
     isSequentialNumber,
     preventEmptyClipboardPaste,
+    isIDVWhitelistDocumentNumber,
 } from '../../idv-document-submit/utils';
-import { useToggleValidation } from '../../../hooks/useToggleValidation';
 import DocumentSubmitLogo from 'Assets/ic-document-submit-icon.svg';
 
 export const IdvDocSubmitOnSignup = ({ citizen_data, has_previous, onPrevious, onNext, value, has_idv_error }) => {
-    const location = useLocation();
-    const validation_is_enabled = useToggleValidation(location?.hash);
     const [document_list, setDocumentList] = React.useState([]);
     const [document_image, setDocumentImage] = React.useState(null);
     const [is_input_disable, setInputDisable] = React.useState(true);
@@ -100,6 +97,14 @@ export const IdvDocSubmitOnSignup = ({ citizen_data, has_previous, onPrevious, o
         const is_sequential_number = isSequentialNumber(document_number);
         const is_recurring_number = isRecurringNumberRegex(document_number);
         const needs_additional_document = !!document_type.additional;
+        const is_idv_whitelist_document_number = isIDVWhitelistDocumentNumber(
+            country_code,
+            document_type.id,
+            document_number
+        );
+        const is_document_number_invalid =
+            (!is_idv_whitelist_document_number && (is_recurring_number || is_sequential_number)) ||
+            document_number === document_type.example_format;
 
         if (!document_type || !document_type.text || !document_type.value) {
             errors.document_type = localize('Please select a document type.');
@@ -117,10 +122,7 @@ export const IdvDocSubmitOnSignup = ({ citizen_data, has_previous, onPrevious, o
         if (!document_number) {
             errors.document_number =
                 localize('Please enter your document number. ') + getExampleFormat(document_type.example_format);
-        } else if (
-            (validation_is_enabled && (is_recurring_number || is_sequential_number)) ||
-            document_number === document_type.example_format
-        ) {
+        } else if (is_document_number_invalid) {
             errors.document_number = localize('Please enter a valid ID number.');
         } else {
             const format_regex = getRegex(document_type.value);
@@ -177,7 +179,17 @@ export const IdvDocSubmitOnSignup = ({ citizen_data, has_previous, onPrevious, o
             validateOnChange
             validateOnBlur
         >
-            {({ errors, handleBlur, handleChange, handleSubmit, isValid, setFieldValue, touched, values }) => (
+            {({
+                errors,
+                handleBlur,
+                handleChange,
+                handleSubmit,
+                isSubmitting,
+                isValid,
+                setFieldValue,
+                touched,
+                values,
+            }) => (
                 <AutoHeightWrapper default_height={450} height_offset={isDesktop() ? 81 : null}>
                     {({ setRef }) => (
                         <form ref={setRef} className='poi-form-on-signup' onSubmit={handleSubmit} noValidate>
@@ -332,8 +344,9 @@ export const IdvDocSubmitOnSignup = ({ citizen_data, has_previous, onPrevious, o
                                                                         }
                                                                         disabled={is_input_disable}
                                                                         error={
-                                                                            touched.document_number &&
-                                                                            errors.document_number
+                                                                            (touched.document_number &&
+                                                                                errors.document_number) ||
+                                                                            errors.error_message
                                                                         }
                                                                         autoComplete='off'
                                                                         placeholder='Enter your document number'
@@ -421,7 +434,9 @@ export const IdvDocSubmitOnSignup = ({ citizen_data, has_previous, onPrevious, o
 
                             <Modal.Footer has_separator is_bypassed={isMobile()}>
                                 <FormSubmitButton
-                                    is_disabled={(!values.document_number && !values.document_type) || !isValid}
+                                    is_disabled={
+                                        (!values.document_number && !values.document_type) || !isValid || isSubmitting
+                                    }
                                     label={localize('Next')}
                                     is_absolute={isMobile()}
                                     has_cancel={has_previous}

packages/account/src/Sections/Verification/ProofOfIdentity/proof-of-identity-submission-for-mt5.jsx

@@ -50,7 +50,8 @@ const POISubmissionForMT5 = ({
             refreshNotifications();
         });
     };
-    const handleIdvSubmit = values => {
+    const handleIdvSubmit = (values, { setSubmitting, setErrors }) => {
+        setSubmitting(true);
         const { document_number, document_type } = values;
         const submit_data = {
             identity_verification_document_add: 1,
@@ -59,7 +60,12 @@ const POISubmissionForMT5 = ({
             issuing_country: citizen_data.value,
         };
 
-        WS.send(submit_data).then(() => {
+        WS.send(submit_data).then(response => {
+            setSubmitting(false);
+            if (response.error) {
+                setErrors({ error_message: response.error.message });
+                return;
+            }
             handlePOIComplete();
         });
     };